Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please quiet down the 14.2 frontend compilation #8104

Open
jflamy opened this issue Apr 19, 2020 · 4 comments
Open

Please quiet down the 14.2 frontend compilation #8104

jflamy opened this issue Apr 19, 2020 · 4 comments

Comments

@jflamy
Copy link

jflamy commented Apr 19, 2020

When developping, we sort of know that Vaadin will be running in debug mode.

Also, the many "=============" and "-------------------" lines give the output a "first-year programming course-just-learned-about-printf-this-is-cool" feeling that does not fit with the rest of the well-polished product.

Suggestion: add a "verboseLevel" configuration option, with 0 meaning error messages only.

Also If I'm running an embedded Tomcat or Jetty and I change the port, it is pointlessly annoying to be given a wrong URL in the instructions.

@jflamy
Copy link
Author

jflamy commented Apr 19, 2020

And while I'm at it, ANSI escape codes for color look annoying in the Eclipse console window. Another option to shut them off would be nice.
Will accept "ok, boomer" as an answer, even though I don't quite qualify :-)

@juhopiirainen
Copy link

Thanks for the ticket @jflamy. I move this to the Flow team for evaluation.

@juhopiirainen juhopiirainen transferred this issue from vaadin/platform Apr 20, 2020
@pleku
Copy link
Contributor

pleku commented Apr 21, 2020

Will accept "ok, boomer" as an answer, even though I don't quite qualify :-)

I don't quite qualify for giving that response either ;)

Thanks for the feedback. I've touched the log output lately for 14.2 and other versions to make it less verbose for the frontend side and to unify the output for the detected configuration used like "You are running development mode...". These were packed inside single ====... intentionally to stand out a bit, but there should be only one output with these.

The message for app is running was intended for more newbie users and even mentions that the port not be valid. This is only done in development mode and yes it is of no information to most users, but for new users we have discovered issues in trying to understand what do and what to make of the overwhelming log output.

Suggestion: add a "verboseLevel" configuration option, with 0 meaning error messages only.

Using defaultLogLevel=warning should be enough for you @jflamy I think ? How to apply it dends on the logging facade used though (like slf4j). The intention is anyway that the above mentioneed output is given at level info, so using warning should work for you.

I'll take a look at this after finishing some ongoing things.

@pleku pleku self-assigned this Apr 21, 2020
@jflamy
Copy link
Author

jflamy commented Apr 21, 2020 via email

pleku added a commit that referenced this issue Jun 1, 2020
Removes highlighting blocks, extra whitespace and always output block
about application start up. Last is now just a oneliner.

Fixes #8404, 8395
Related to #8104
pleku added a commit that referenced this issue Jun 1, 2020
Removes highlighting blocks, extra whitespace and changes output block
about application start up to a oneliner.

Fixes #8404, 8395
Related to #8104
pleku added a commit that referenced this issue Jun 1, 2020
Removes highlighting blocks, extra whitespace and changes output block
about application start up to a oneliner.

Fixes #8404, 8395
Related to #8104
pleku added a commit that referenced this issue Jun 2, 2020
Removes highlighting blocks, extra whitespace and changes output block
about application start up to a oneliner.

Fixes #8404, 8395
Related to #8104
pleku added a commit that referenced this issue Jun 2, 2020
Removes highlighting blocks, extra whitespace and changes output block
about application start up to a oneliner.

Fixes #8404, 8395
Related to #8104
denis-anisimov pushed a commit that referenced this issue Jun 3, 2020
Removes highlighting blocks, extra whitespace and changes output block
about application start up to a oneliner.

Fixes #8404, 8395
Related to #8104
mshabarov pushed a commit that referenced this issue Aug 24, 2020
Removes highlighting blocks, extra whitespace and changes output block
about application start up to a oneliner.

Fixes #8404, 8395
Related to #8104
@caalador caalador moved this to 🔖 Normal Priority (P2) in Vaadin Flow bugs & maintenance (Vaadin 10+) Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🔖 Normal Priority (P2)
Development

No branches or pull requests

3 participants