-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed redundant colons from docs #284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to contribute to {pkgnet}
, @KKulma ! This looks good to me, but I'll double check tonight by re-installing the package and running ?CreatePackageReport
I did notice one issue...did you notice that this commit doesn't mention your username?
I've had that situation before doing open source stuff. I think you should fix this before we merge, so you'll show up in the list of {pkgnet}
contributors!
In case you've never seen it, I'll explain here:
It means your local git
isn't configured with an email address tied to your GitHub account.
You can fix by running these commands from the root of your copy of pkgnet
(substituting in your email)
git config --global user.email "[email protected]"
git reset --soft HEAD~1
git commit -m "removed redundant colons from docs"
git push origin master --force
You'll know this worked if you go to https://github.com/uptake/pkgnet/pull/284/commits and see your username on the commit 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me as well.
hi there! Thanks so much for such a thorough commentary and a small tutorial and how to set up my git config 👍 Never paid attention to how my commits appear! Anywho, it's all fixed now and thanks again for accepting my contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks again for taking the time to contribute here. We hope you'll come back to contribute in the future!
Co-authored-by: Kasia <[email protected]>
resolves #277