Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress categorical warning (fixes #3379) #4762

Closed
wants to merge 1 commit into from

Conversation

hzy46
Copy link
Contributor

@hzy46 hzy46 commented Nov 2, 2021

To fix #3379

@jameslamb jameslamb changed the title Suppress categorical warning Suppress categorical warning (fixes #3379) Nov 2, 2021
@jameslamb
Copy link
Collaborator

I just added (fixes #3379) to the PR description. I try to do this whenever I open a PR that fixes another issue. PR titles become items in the release notes (e.g. https://github.com/microsoft/LightGBM/releases/tag/v3.3.1), and having the fixes #xxxx there makes it easy for users who want to learn more about a particular item in the release notes to click through to the underlying issue.

@jameslamb
Copy link
Collaborator

oh! Also @hzy46 please check your ~/.gitconfig. It looks like the commits you've pushed here aren't tied to your GitHub account.

Notice that your profile picture is not showing up:

image

See my suggestions in #3607 (comment) and uptake/pkgnet#284 (review) for how to fix this.

_log_warning('Overriding the parameters from Reference Dataset.')
params = self.get_params()
if params != reference_params:
if self._compare_params_for_warning(params, reference_params) is False:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to get_params, both params and reference_params can be None. In this case they cannot be directly iterated in the _compare_params_for_warning method.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks shiyu. I also found this issue in the CI. Will add a check on this.

@hzy46 hzy46 force-pushed the suppress_categorical_warning branch from 93c2e72 to fe166b1 Compare November 3, 2021 09:06
@hzy46
Copy link
Contributor Author

hzy46 commented Nov 4, 2021

Close this to use another PR.

@hzy46 hzy46 closed this Nov 4, 2021
@hzy46
Copy link
Contributor Author

hzy46 commented Nov 4, 2021

Thanks @jameslamb . I used a different PR. Now the author info issue should be addressed in #4768

@jameslamb
Copy link
Collaborator

I used a different PR. Now the author info issue should be addressed in

Thanks! It looks like you already did git reset, squashed the commits from this PR, and force-pushed them here so another PR wasn't necessary. I can see that the commit on this PR is tied to your user.

image

But we can review the new PR and keep this, no problem! Just letting you know in case you have this problem in the future.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[python] suppress the warning about categorical feature override
3 participants