-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Python Dockerfile #5984
Fix Python Dockerfile #5984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to contribute!
Please see one suggestion I left. In the future, we'd appreciate if you tested your changes prior to submitting them.
docker/dockerfile-python
Outdated
@@ -26,7 +26,7 @@ RUN apt-get update && \ | |||
# lightgbm | |||
conda install -q -y numpy scipy scikit-learn pandas && \ | |||
git clone --recursive --branch stable --depth 1 https://github.com/Microsoft/LightGBM && \ | |||
sh ./build-python.sh install && \ | |||
cd LigthGBM && sh ./build-python.sh install && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cd LigthGBM && sh ./build-python.sh install && \ | |
cd ./LightGBM && \ | |
sh ./build-python.sh install && \ |
Please put this change on a separate line, for consistency with the rest of this Dockerfile (which is done to make it easier to see the sequence of commands).
And please note that it's LightGBM
, not LihgtGBM
.
I misspelled it when I typed it in the source after testing it on something else. Next time I contribute, I'll be sure to test or build against the changed source and open a PR. Thanks for the thoughtful comment. |
No problem, thanks for the fix! By the way, please check you gitconfig settings. It looks like you're pushing commits here that aren't signed with an email tied to your GitHub account. That means GitHub might not include you as a "contributor" in this project's statistics, and people won't be able to click through to your account from the commit log or git blame view. See #5532 (comment) for some details on what I mean. |
3d1506f
to
bc98641
Compare
i did below code. ( ref, uptake/pkgnet#284)
Is this what you were expecting? |
thanks! |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
dockerfile is updated 2 month ago.
there is missed change directory command. (it is originally existed)