-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python-package] prefix cast_numpy_array_to_dtype with _ #5532
Conversation
@Madnex , I think you might want to change the commit on this PR prior to it being merged. Do you see how the profile picture from your GitHub account isn't displayed? That means that you do not have your email set in your See the suggestions in #3607 (comment) for how to fix this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thanks! I'll wait a few days to hear if you want to fix the commit attribution before merging this.
f4e41d4
to
e98532d
Compare
Thanks for the tipp! I added my email in the git config :) For the next changes in basic.py should I keep creating PRs for each function? Or should I aggregate several commits before submitting a PR? |
commits look good to me, thanks!
It's ok to start grouping a few together in each PR, now that you've done a few of these. Thanks very much for your help with this project! |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Contributes to #5313