Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-package] prefix cast_numpy_array_to_dtype with _ #5532

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

Madnex
Copy link
Contributor

@Madnex Madnex commented Oct 10, 2022

Contributes to #5313

@jameslamb
Copy link
Collaborator

@Madnex , I think you might want to change the commit on this PR prior to it being merged.

Screen Shot 2022-10-10 at 10 13 28 PM

Do you see how the profile picture from your GitHub account isn't displayed? That means that you do not have your email set in your ~/.gitconfig to one that is tied to your GitHub account.

See the suggestions in #3607 (comment) for how to fix this.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks! I'll wait a few days to hear if you want to fix the commit attribution before merging this.

@Madnex Madnex force-pushed the cast_numpy_array_to_dtype branch from f4e41d4 to e98532d Compare October 11, 2022 05:57
@Madnex
Copy link
Contributor Author

Madnex commented Oct 11, 2022

Thanks for the tipp! I added my email in the git config :)

For the next changes in basic.py should I keep creating PRs for each function? Or should I aggregate several commits before submitting a PR?

@jameslamb
Copy link
Collaborator

commits look good to me, thanks!

For the next changes in basic.py should I keep creating PRs for each function

It's ok to start grouping a few together in each PR, now that you've done a few of these.

Thanks very much for your help with this project!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants