Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Recover running CUDA tests at CI (fixed #4611) #4621

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

shiyu1994
Copy link
Collaborator

The NVIDIA driver on the ci CUDA machine has been reloaded, and now we can recover the CUDA tests.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 awesome, thank you so much!

And looks like they all passed, so no new CUDA-specific problems were introduced in the brief period these jobs weren't running.

@jameslamb
Copy link
Collaborator

@shiyu1994 just a very small thing...I noticed that your commit on this PR wasn't linked to your GitHub account

image

That probably means that your ~/.gitconfig currently uses an email address that is not tied to your GitHub account. When this happens, it means that the lines you changed in PR's won't count in the "Contributors" view on the project's homepage. That doesn't matter much for this one, but would definitely want to be sure you get full credit for work on bigger PRs where I also see this issue, like #4528.

In case you've never dealt with this before, you can see uptake/pkgnet#284 (review) for information on how to fix it.

But to be clear...I don't think it needs to be blocking for this PR.

@StrikerRUS StrikerRUS changed the title [ci] Recover running CUDA tests at CI (#4611) [ci] Recover running CUDA tests at CI (fixed #4611) Sep 23, 2021
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @shiyu1994 !

@shiyu1994
Copy link
Collaborator Author

@jameslamb Thanks a lot for the reminder. I'll fix it.

@shiyu1994 shiyu1994 merged commit b1c261a into microsoft:master Sep 23, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants