Merge main from dbt-core #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….yml (#7185) * Add deprecation warnings for log-path, target-path in dbt_project.yml * Fix tests/unit/test_events * Fix failing tests * PR feedback
* reformat test directory to pass formatting checks * remove test comment
* add protobuf message/class for new CommandCompleted event For [CT-2049](#6878) we concluded that we wanted a new event type, [CommandCompleted](#6878 (comment)) with [four (4) values](#6878 (comment)): which command was run, whether the command succeeded, the timestamp that the command finished, and how long the command took. This commit adds the new event proto defition, the auto generated proto_types, and the instantiatable even type. * begin emitting CommandCompleted event in the preflight decorator The [preflight decorator](https://github.com/dbt-labs/dbt-core/blob/4186f99b742b47e0e95aca4f604cc09e5c67a449/core/dbt/cli/requires.py#L19) runs at the start of every CLI invocation. Thus is a perfect candidate for emitting the CommandCompleted event. This is noted in the [dicussion on CT-2049](#6878 (comment)). * add CommandCompleted event to event unit tests * Add: changelog entry * fire CommandCompleted event reguardless of upstream exceptions Previously, if `--fail-fast` was specified and an issue was run into or an unhandled issue became an exception, the CommandCompleted event would not get fired because at this point in the stack we'd be in exception thrown handling mode. If an exception does reach this point, we want to still fire the event and also continue to propogate the exception. Hence the bare `raise` exists to reraise the caught exception * Update CommandCompleted event to be a `Debug` level event We don't actually "always" need this event to be logged. Thus we've updated it to `Debug` level. [Discussion Context](#7180 (comment))
* ct-2198: clean up some type names and uses * CT-2198: Unify constraints and constraints_check properties on columns * Make mypy version consistently 0.981 (#7134) * CT 1808 diff based partial parsing (#6873) * model contracts on models materialized as views (#7120) * first pass * rename tests * fix failing test * changelog * fix functional test * Update core/dbt/parser/base.py * Update core/dbt/parser/schemas.py * Create method for env var deprecation (#7086) * update to allow adapters to change model name resolution in py models (#7115) * update to allow adapters to change model name resolution in py models * add changie * fix newline adds * move quoting into macro * use single quotes * add env DBT_PROJECT_DIR support #6078 (#6659) Co-authored-by: Jeremy Cohen <[email protected]> * Add new index.html and changelog yaml files from dbt-docs (#7141) * Make version configs optional (#7060) * [CT-1584] New top level commands: interactive compile (#7008) Co-authored-by: Github Build Bot <[email protected]> * CT-2198: Add changelog entry * CT-2198: Fix tests which broke after merge * CT-2198: Add explicit validation of constraint types w/ unit test * CT-2198: Move access property, per code review * CT-2198: Remove a redundant macro * CT-1298: Rework constraints to be adapter-generated in Python code * CT-2198: Clarify function name per review --------- Co-authored-by: Gerda Shank <[email protected]> Co-authored-by: Emily Rockman <[email protected]> Co-authored-by: Stu Kilgore <[email protected]> Co-authored-by: colin-rogers-dbt <[email protected]> Co-authored-by: Leo Schick <[email protected]> Co-authored-by: Jeremy Cohen <[email protected]> Co-authored-by: FishtownBuildBot <[email protected]> Co-authored-by: dave-connors-3 <[email protected]> Co-authored-by: Kshitij Aranke <[email protected]> Co-authored-by: Github Build Bot <[email protected]>
* Convert simple copy. * Adjust class names for import. * adjust test namespacing * Resolve test error. --------- Co-authored-by: Mila Page <[email protected]>
* add utility function to EventManager for explicitly adding callbacks Technically these aren't necessary in their current state. We could instead have people do `<InstantiatedEventManager>.callbacks.extend(...)` directly. However, it's not hard to imagine a world wherein extra things need to take place when a callback is added. Thus abstracting to a utility method now means that as the implementation of how callbacks are actually added changes, the invocation to do so can stay the same. * update `setup_event_logger` to optionally take in callbacks add them to the EventManager * update preflight decorator to check for and pass along callbacks for event logger setup * Add `callbacks` to `dbtRunner` On instantiation of `dbtRunner` one can now provide `callbacks`. These callbacks are for the `EventLogger`. When `invoke` is called on a `dbtRunner`, the `callbacks` are added to the cli context object. In the preflight decorator these callbacks are extracted from the cli context and then passed to the `setup_event_logger`, finally `setup_event_logger` ensures the callbacks are added to the global `EVENT_MANAGER`. * add test to check dbtRunner callbacks get properly set I believe technically this tests qualifies as more of an integration test, but no other tests like it currently exist (that I could find via a cursory search). The `tests/unit/test_dbt_runner.py` seemed like the most intuitive spot. However, if somewhere else makes sense, I'd be happy to move it. * add changie documentation for CT-1928
…ing the job queue (#7192)
* CT-2129: added timeout for dbt version * CT-2129: updated CHANGELOG.md * delete the files added under core/dbt/.changes
* first pass * adding tests * changelog * split up tests due to order importance * update test * add back comment * rename base test classes * move sql * fix test name * move sql * test changes to match main * organize and cleanup fixtures * more cleanup of tests
* One argument per line * Tests for multiple `--select` or `--exclude` * Allow `--select` and `--exclude` multiple times * Changelog entry * MultiOption options must be specified with type=tuple or type=ChoiceTuple * Testing for `--output-keys` and `--resource-type` * Validate that any new param with `MultiOption` should also have `type=tuple` (or `ChoiceTuple`) and `multiple=True`
* first pass at changes before modifying tests * test updates * add default * update manifest * fix tests * changelog * fix unit tests * rename strict -> enforced * convert to object * fix tests * Update Under the Hood-20230217-105223.yaml * Update Under the Hood-20230217-105223.yaml * remove stray breakpoints * move Contract definition to model_config * fix contract reference
…uring release process
* Bump black from 22.12.0 to 23.3.0 Bumps [black](https://github.com/psf/black) from 22.12.0 to 23.3.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@22.12.0...23.3.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Add automated changelog yaml from template for bot PR --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Github Build Bot <[email protected]>
* remove deprecated exception functions * fully remove deprecated exception functions
* add double to float types for columns * add changie item
…ker (#7196) * Bump python from 3.11.1-slim-bullseye to 3.11.2-slim-bullseye in /docker Bumps python from 3.11.1-slim-bullseye to 3.11.2-slim-bullseye. --- updated-dependencies: - dependency-name: python dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Add automated changelog yaml from template for bot PR --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Github Build Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
Description
Checklist
changie newto create a changelog entry