Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT-2129 Bug: added timeout for dbt version #7009

Merged
merged 3 commits into from
Mar 28, 2023

Conversation

Goodkat
Copy link
Contributor

@Goodkat Goodkat commented Feb 19, 2023

resolves #6992

Description

In many compagnies access to the internet is restricted. In that case dbt --version does wait forever and never exits.
Make check at PyPi optional, or at least, timeout this check after some time in a proper way.

Checklist

@Goodkat Goodkat requested review from a team and iknox-fa February 19, 2023 10:10
@cla-bot cla-bot bot added the cla:yes label Feb 19, 2023
@Goodkat Goodkat requested a review from a team as a code owner February 19, 2023 11:01
@jtcohen6 jtcohen6 added Team:Execution ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering labels Feb 19, 2023
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Goodkat Thanks for opening up the PR!

Could you delete the files added under core/dbt/.changes? (I'm guessing that's the effect of having run changie from the core/dbt directory, instead of the codebase's root directory)

@Goodkat Goodkat requested review from jtcohen6 and removed request for ChenyuLInx and iknox-fa February 19, 2023 17:59
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Goodkat Thanks for adding this!! It looks good to me!

@ChenyuLInx ChenyuLInx merged commit 14e2c3e into dbt-labs:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2129] [Bug] dbt --version hangs when access to PyPi is not available
3 participants