Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert simple copy. #7205

Merged
merged 4 commits into from
Mar 22, 2023
Merged

Convert simple copy. #7205

merged 4 commits into from
Mar 22, 2023

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented Mar 22, 2023 •
edited
Loading

Description

Conversion of simple copy related tests. I've moved them to the adapter zone in order to be used in downstream models.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR

@VersusFacit VersusFacit added the Skip Changelog Skips GHA to check for changelog file label Mar 22, 2023
@VersusFacit VersusFacit self-assigned this Mar 22, 2023
@cla-bot cla-bot bot added the cla:yes label Mar 22, 2023
@VersusFacit VersusFacit marked this pull request as ready for review March 22, 2023 20:02
@VersusFacit VersusFacit requested review from a team as code owners March 22, 2023 20:02
@VersusFacit VersusFacit requested review from nssalian, dbeatty10 and McKnight-42 and removed request for nssalian March 22, 2023 20:02
@VersusFacit VersusFacit merged commit 2cfc386 into main Mar 22, 2023
@VersusFacit VersusFacit deleted the ADAP-13/simple_copy_test_conversion branch March 22, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McKnight-42 McKnight-42 McKnight-42 approved these changes

@dbeatty10 dbeatty10 Awaiting requested review from dbeatty10 dbeatty10 was automatically assigned from dbt-labs/core-group

Assignees

@VersusFacit VersusFacit

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VersusFacit @McKnight-42