Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Missed Commit] Replace tracking events: project_id, adapter_info #7240

Merged
merged 12 commits into from
Mar 29, 2023

Conversation

iknox-fa
Copy link
Contributor

A commit didn't get pushed for #7231 moving the call sites for the tracking to requires.py.
This PR remedies that.

@iknox-fa iknox-fa requested a review from a team March 29, 2023 17:02
@iknox-fa iknox-fa requested a review from a team as a code owner March 29, 2023 17:02
@cla-bot cla-bot bot added the cla:yes label Mar 29, 2023
@iknox-fa iknox-fa requested review from stu-k and removed request for McKnight-42 March 29, 2023 17:03
Copy link
Contributor

@stu-k stu-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the tracking in tasks/base.py as part of this PR as well?

Looking at the changes between this branch and main, you may want to rebase on main, I think some of the work in his PR already exists there (the alphabetization, the track_project_id and track_adapter_info functions, the events/README.md file).

@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@iknox-fa
Copy link
Contributor Author

Should we remove the tracking in tasks/base.py as part of this PR as well?

Looking at the changes between this branch and main, you may want to rebase on main, I think some of the work in his PR already exists there (the alphabetization, the track_project_id and track_adapter_info functions, the events/README.md file).

Oh git.
All updated @stu-k
:)

@iknox-fa iknox-fa added the Skip Changelog Skips GHA to check for changelog file label Mar 29, 2023
@iknox-fa iknox-fa merged commit 567e2ca into main Mar 29, 2023
@iknox-fa iknox-fa deleted the iknox/CT-1368-1368-GH-6097-6098-replace-tracking-events branch March 29, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants