Support label matchers in labels API #3566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E is flaky #3570 |
onprem
reviewed
Dec 12, 2020
| matcherSets = append(matcherSets, matchers) | ||
| } | ||
|
|
||
| q, err := qapi.queryableCreate(true, nil, storeDebugMatchers, 0, enablePartialResponse, true). |
There was a problem hiding this comment.
Not a nit, just wanted to ask a question. Why did you flip the last argument (skipChunks) to true, and what it does exactly?
There was a problem hiding this comment.
A query result contains two parts, the series metadata like label sets, and the sample values. In this case, since we are just querying labels, we can set skipChunks to not return samples, only labels are fine.
There was a problem hiding this comment.
This is the original issue about this option #1822.
Also this Prometheus pr prometheus/prometheus#8050 has the same idea to improve the performance.
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
yeya24
force-pushed
the
labels-matchers
branch
from
2783aaf
to
bbde4ab
Compare
bwplotka
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye [email protected]
Changes
Fixes #3351
Add
match[]param for LabelNames and LabelValues queries.Now this is implemented via the
Seriesmatching. We can do matchers push down to improve this later.TODO: query frontend also needs
matcherstype for Label names and label values query. Will add them in the next pr.Verification
Add unit tests and E2E tests for this feature.