Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-chunks Store.Series option to StoreAPI #1822

Closed
bwplotka opened this issue Dec 2, 2019 · 3 comments · Fixed by #1904
Closed

Add no-chunks Store.Series option to StoreAPI #1822

bwplotka opened this issue Dec 2, 2019 · 3 comments · Fixed by #1904

Comments

@bwplotka
Copy link
Member

bwplotka commented Dec 2, 2019

Querier HTTP /series API is returning metadata, so series matched by labels.

For Thanos this uses StoreAPI.Series which also returns full chunks for whole requested time period. However the only labelset is required.

I would propose:

  • Extend Series method of StoreAPI with some no-chunk bool or enum. This is to let know all implementations to do not send any samples, just labels of series. We might adjust the response, or just stream series with zero chunks. I think the latter makes sense.
  • Sidecar then based on this can decide to use series API of Prometheus instead of remote read (:
@daixiang0
Copy link
Member

I would like to do this. Before it, i want to confirm the work:

  • Add an option like seriers-address which uses the rule of StoreAPI
  • Support sidecar read from series API

@GiedriusS
Copy link
Member

Hi @daixiang0,

I would like to do this. Before it, i want to confirm the work:

* Add an option like `seriers-address` which uses the rule of StoreAPI

* Support sidecar read from series API

What do you mean by

Add an option like seriers-address which uses the rule of StoreAPI

?

Btw, the original proposal by @bwplotka IMHO makes sense. We should also probably mention in this ticket that it came from #1774 and should fix it.

@bwplotka
Copy link
Member Author

bwplotka commented Dec 6, 2019

Please elaborate @daixiang0 (: what rule here means?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants