Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query frontend: Flaky E2E test #3570

Closed
yeya24 opened this issue Dec 11, 2020 · 6 comments
Closed

query frontend: Flaky E2E test #3570

yeya24 opened this issue Dec 11, 2020 · 6 comments

Comments

@yeya24
Copy link
Contributor

yeya24 commented Dec 11, 2020

What happened:

https://github.com/thanos-io/thanos/pull/3566/checks?check_run_id=1534028614

=== RUN   TestQueryFrontend/query_frontend_works_for_instant_query
queryAndAssert: Waiting for 1 results for query sum(up) without (instance)
=== RUN   TestQueryFrontend/query_frontend_works_for_range_query_and_it_can_cache_results
=== CONT  TestQueryFrontendMemcachedCache
Error:     query_frontend_test.go:467: query_frontend_test.go:467:
        
         unexpected error: unable to find metrics [thanos_frontend_split_queries_total] with expected values. Last error: <nil>. Last values: [2]
        
23:20:43 Killing query-frontend-1

The query splitting test case is flaky because we are using the current timestamp to send queries, which makes the splitting behavior non-deterministic.

@yeya24 yeya24 self-assigned this Dec 11, 2020
@yeya24 yeya24 added the bug label Dec 11, 2020
@kakkoyun kakkoyun changed the title Flaky query frontend E2E test query frontend: Flaky E2E test Dec 17, 2020
@stale
Copy link

stale bot commented Feb 15, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Feb 15, 2021
@stale
Copy link

stale bot commented Mar 5, 2021

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Mar 5, 2021
@wiardvanrij
Copy link
Member

Still relevant

@wiardvanrij
Copy link
Member

wiardvanrij commented Dec 22, 2021

If the start and end time falls between a new day (passed 23:59), it will see this as '24h' (default --query-range.split-interval). My guess is that certain behavior has an underlying bug or that I'm a lost in the complexity. It will need to double the testing values if the hour is "1" for thanos_frontend_split_queries_total and cortex_cache_* However, only thanos_frontend_split_queries_total will need to double its value on hour 0. cortex_cache_*'s do not. This makes no sense to me and I also can't figure out why..

@stale
Copy link

stale bot commented Mar 2, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Mar 2, 2022
@stale
Copy link

stale bot commented Apr 17, 2022

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants