Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support matchers in gRPC LabelNames and LabelValues requests #3637

Closed
yeya24 opened this issue Dec 17, 2020 · 8 comments
Closed

Support matchers in gRPC LabelNames and LabelValues requests #3637

yeya24 opened this issue Dec 17, 2020 · 8 comments

Comments

@yeya24
Copy link
Contributor

yeya24 commented Dec 17, 2020

Initial support for label matchers API is done in #3566.

It just simply sends Series requests to stores and deduplicate the results at the API level.

It works but we might improve more by adding matchers to LabelNames and LabelValues gRPC requests to push down matchers to each store. Each store can get the matched labels and send them back. The network load would be better.

AC:

  1. Add matchers to LabelNames and LabelValues gRPC requests
  2. For each store, implement the logic to filter the labels based on the given matchers
@Biswajitghosh98
Copy link
Contributor

Biswajitghosh98 commented Jan 13, 2021

@yeya24 I'd like to give it a try.

@yeya24
Copy link
Contributor Author

yeya24 commented Jan 13, 2021

Sorry for being unclear. I am already working on this one. Currently blocked by #3639

@Biswajitghosh98
Copy link
Contributor

No worries. I'll pick a different issue 😄

@stale
Copy link

stale bot commented Mar 16, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Mar 16, 2021
@onprem onprem removed the stale label Apr 1, 2021
@pstibrany
Copy link
Contributor

pstibrany commented Apr 23, 2021

Hello, if there is no update on this, I would like to implement support for matchers in LabelNames and LabelValues calls in Thanos store (gateway) component. (*BucketStore type).

My plan is to mimick the implementation in Prometheus TSDB: basically call blockSeries with supplied matchers (in case of LabelValues, matchers would be extended with labelName!="") but no chunk-fetching. From returned series set, code would extract unique label names or label values and return them. If no matchers were used, we would reuse current implementation.

My plan does not include implementing support for matchers in other StoreServer implementations.

@yeya24 Please let me know if you are still working on this or have other plans, or I can go ahead with my plan.

Thank you!

@bwplotka
Copy link
Member

Sounds good to me! I think we started some work on sidecar but not for store.

@stale
Copy link

stale bot commented Jun 22, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jun 22, 2021
@yeya24
Copy link
Contributor Author

yeya24 commented Jun 22, 2021

This has been solved. Close.

@yeya24 yeya24 closed this as completed Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants