-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support matchers in gRPC LabelNames and LabelValues requests #3637
Comments
@yeya24 I'd like to give it a try. |
Sorry for being unclear. I am already working on this one. Currently blocked by #3639 |
No worries. I'll pick a different issue 😄 |
Hello 👋 Looks like there was no activity on this issue for the last two months. |
Hello, if there is no update on this, I would like to implement support for matchers in My plan is to mimick the implementation in Prometheus TSDB: basically call My plan does not include implementing support for matchers in other @yeya24 Please let me know if you are still working on this or have other plans, or I can go ahead with my plan. Thank you! |
Sounds good to me! I think we started some work on sidecar but not for store. |
Hello 👋 Looks like there was no activity on this issue for the last two months. |
This has been solved. Close. |
Initial support for label matchers API is done in #3566.
It just simply sends
Series
requests to stores and deduplicate the results at the API level.It works but we might improve more by adding matchers to
LabelNames
andLabelValues
gRPC requests to push down matchers to each store. Each store can get the matched labels and send them back. The network load would be better.AC:
matchers
toLabelNames
andLabelValues
gRPC requestsThe text was updated successfully, but these errors were encountered: