Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyTorch Tracing Sweeps #13373

Closed
3 tasks done
Tracked by #13795
eyonland opened this issue Oct 2, 2024 · 1 comment
Closed
3 tasks done
Tracked by #13795

PyTorch Tracing Sweeps #13373

eyonland opened this issue Oct 2, 2024 · 1 comment
Assignees
@KalaivaniMCW
Labels
master MCW op_cat: eltwise P1

Comments

@eyonland
Copy link
Contributor

eyonland commented Oct 2, 2024 •
edited by VirdhatchaniKN
Loading

For these PyTorch Sweep the tracing files have already been created. See the markdown files in https://github.com/tenstorrent/pytorch2.0_ttnn/tree/main/docs/operations for all tracing that was done. The md files for the eltwise ops need to be transformed and put in a the location https://github.com/tenstorrent/tt-metal/tree/main/tests/sweep_framework/sweeps/eltwise/aten/ for now so that we can easily identify them.
A video describing the tracing and what we need to use is described here : https://tenstorrent.zoom.us/rec/share/UI9t4RYxxcdLAMXlUM7jbNsECr5XE_zjdbatFRpUCYhPUDv61AKvKrEq0gOap-zl.Nvl8-dLXnkZlWslj Passcode:
Jasmina took the time to list all the ops (including eltwise) here: https://docs.google.com/spreadsheets/d/1xqBex_wjnqiCiweTWSgf-xnWljKjiUHoDDzdE7EPxzI/edit?gid=0#gid=0 to help us track them.

Our goal here is to generate the sweeps, collect the number of passing/failures vs totals, and then update the appropriate locations within the referenced links here: https://docs.google.com/spreadsheets/d/1RzpC1upgh-UR_y5Lk8nWpSOOmvX-xTEOf2vJFCB5jNk/edit?gid=2026993254#gid=2026993254
Note: The number of failures we get from these sweeps will determine the priority of our bugs. Specifically, these bugs become our top priority outside of P0s
Ideally only one or two people work on this. We need to try an get this done within two days. To hit this goal we will need to think smart and possibly leverage ChatGPT like Atul did, or we use python or something else to quickly crank out these sweeps and run them.

Sweep test Results Tracker: Link
mouliraj-mcw added a commit that referenced this issue Oct 3, 2024
@mouliraj-mcw
#13373: Add sweeps for relu_pytorch2
b23fafc
vigneshkeerthivasanx pushed a commit that referenced this issue Oct 3, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for clamp
7b17f34
vigneshkeerthivasanx pushed a commit that referenced this issue Oct 3, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for clamp
6051758
vigneshkeerthivasanx pushed a commit that referenced this issue Oct 3, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for clamp, clamp_min
053fbf6
vigneshkeerthivasanx pushed a commit that referenced this issue Oct 3, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for clamp , clamp_min
39b5bfb
vigneshkeerthivasanx pushed a commit that referenced this issue Oct 3, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for clamp , clamp_min
8658940
vigneshkeerthivasanx pushed a commit that referenced this issue Oct 3, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for clamp , clamp_min
62ffd84
vigneshkeerthivasanx pushed a commit that referenced this issue Oct 3, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for hardswish
58a26e2
vigneshkeerthivasanx pushed a commit that referenced this issue Oct 3, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for hardswish
9d6a859
vigneshkeerthivasanx pushed a commit that referenced this issue Oct 3, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for set 2
474cb4f
mouliraj-mcw added a commit that referenced this issue Oct 3, 2024
@mouliraj-mcw
#13373: Add sweeps for relu_pytorch2
9a580c7
mouliraj-mcw added a commit that referenced this issue Oct 3, 2024
@mouliraj-mcw
#13373: Add sweep test for sin_pytorch2
0abd316
mouliraj-mcw added a commit that referenced this issue Oct 3, 2024
@mouliraj-mcw
#13373: Add sweep test for maximum_pytorch2
9580621
mouliraj-mcw added a commit that referenced this issue Oct 3, 2024
@mouliraj-mcw
#13373: Add sweep test for minimum_pytorch2
7a785a0
mouliraj-mcw added a commit that referenced this issue Oct 3, 2024
@mouliraj-mcw
#13373: Add sweep test for tanh_pytorch2
e17ad06
@mouliraj-mcw mouliraj-mcw mentioned this issue Oct 3, 2024
Merged
1 task
vigneshkeerthivasanx pushed a commit that referenced this issue Oct 3, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for set 2
2b49926
vigneshkeerthivasanx pushed a commit that referenced this issue Oct 3, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for set 2
9c385b6
vigneshkeerthivasanx pushed a commit that referenced this issue Oct 3, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for set 2
eb0951f
vigneshkeerthivasanx pushed a commit that referenced this issue Oct 4, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for set 2
ad6cfcf
VirdhatchaniKN added a commit that referenced this issue Oct 4, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for set 2 ops
315eba0
VirdhatchaniKN added a commit that referenced this issue Oct 4, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for set 2
3325596
VirdhatchaniKN added a commit that referenced this issue Oct 4, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for set 2
b12ced6
VirdhatchaniKN added a commit that referenced this issue Oct 4, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for set 2
785de48
VirdhatchaniKN added a commit that referenced this issue Oct 4, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for set 2
3256a7b
VirdhatchaniKN added a commit that referenced this issue Oct 4, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for set 2
1102fad
mouliraj-mcw added a commit that referenced this issue Oct 9, 2024
@mouliraj-mcw
#13373: Add sweep test for maximum_pytorch2
b96d959
mouliraj-mcw added a commit that referenced this issue Oct 9, 2024
@mouliraj-mcw
#13373: Add sweep test for minimum_pytorch2
45ead5e
mouliraj-mcw added a commit that referenced this issue Oct 9, 2024
@mouliraj-mcw
#13373: Add sweep test for tanh_pytorch2
4f7f1a6
mouliraj-mcw added a commit that referenced this issue Oct 9, 2024
@mouliraj-mcw
#13373: Add sweep test for silu_pytorch2
13d49d7
mouliraj-mcw added a commit that referenced this issue Oct 9, 2024
@mouliraj-mcw
#13373: Add sweep test for rsub_pytorch2
86d2b13
mouliraj-mcw added a commit that referenced this issue Oct 9, 2024
@mouliraj-mcw
#13373: Add sweep test for sigmoid_pytorch2
17e8a9b
mouliraj-mcw added a commit that referenced this issue Oct 9, 2024
@mouliraj-mcw
#13373: Add sweep test for rsqrt_pytorch2
f93de59
mouliraj-mcw added a commit that referenced this issue Oct 9, 2024
@mouliraj-mcw
#13373: Add sweep test for where_pytorch2
0547f50
mouliraj-mcw added a commit that referenced this issue Oct 9, 2024
@mouliraj-mcw
#13373: Add sweep test for tril_pytorch2
2e23afe
mouliraj-mcw added a commit that referenced this issue Oct 9, 2024
@mouliraj-mcw
#13373: Update files
2f86076
mouliraj-mcw added a commit that referenced this issue Oct 9, 2024
@mouliraj-mcw
#13373: Add sweep for pow_scalar_pytorch2, pow_tensor_pytorch2
bc1c2d1
mouliraj-mcw added a commit that referenced this issue Oct 9, 2024
@mouliraj-mcw
#13373: Update golden functions
170f539
mouliraj-mcw added a commit that referenced this issue Oct 9, 2024
@mouliraj-mcw
#13373: PyTorch Tracing Sweeps - Eltwise set 3 (#13435)
399c744 
* #13373: Add sweeps for relu_pytorch2

* #13373: Add sweep test for sin_pytorch2

* #13373: Add sweep test for maximum_pytorch2

* #13373: Add sweep test for minimum_pytorch2

* #13373: Add sweep test for tanh_pytorch2

* #13373: Add sweep test for silu_pytorch2

* #13373: Add sweep test for rsub_pytorch2

* #13373: Add sweep test for sigmoid_pytorch2

* #13373: Add sweep test for rsqrt_pytorch2

* #13373: Add sweep test for where_pytorch2

* #13373: Add sweep test for tril_pytorch2

* #13373: Update files

* #13373: Add sweep for pow_scalar_pytorch2, pow_tensor_pytorch2

* #13373: Update golden functions
@eyonland eyonland mentioned this issue Oct 15, 2024
Open
VirdhatchaniKN added a commit that referenced this issue Oct 16, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for set 2
7bc6bbc
VirdhatchaniKN added a commit that referenced this issue Oct 16, 2024
@VirdhatchaniKN
#13373: Update golden function
dae8b79
VirdhatchaniKN added a commit that referenced this issue Oct 16, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for set 2
a65136f
VirdhatchaniKN added a commit that referenced this issue Oct 16, 2024
@VirdhatchaniKN
#13373: Update golden function
466f7bf
@KalaivaniMCW KalaivaniMCW mentioned this issue Oct 16, 2024
Closed
VirdhatchaniKN added a commit that referenced this issue Oct 16, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for set 2
2f6a632
VirdhatchaniKN added a commit that referenced this issue Oct 16, 2024
@VirdhatchaniKN
#13373: Update golden function
bec8221
VirdhatchaniKN added a commit that referenced this issue Oct 16, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for set 2
a1db5f3
VirdhatchaniKN added a commit that referenced this issue Oct 16, 2024
@VirdhatchaniKN
#13373: Update golden function
69ca7ce
VirdhatchaniKN added a commit that referenced this issue Oct 16, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps for set 2
f31bb5c
VirdhatchaniKN added a commit that referenced this issue Oct 16, 2024
@VirdhatchaniKN
#13373: Update golden function
7bd0fa9
VirdhatchaniKN added a commit that referenced this issue Oct 16, 2024
@VirdhatchaniKN
#13373: PyTorch Tracing Sweeps - Eltwise set 2 (#13421)
e71b3e8 
* #13373: PyTorch Tracing Sweeps for set 2

* #13373: Update golden function

* #13421: Update

* #13421: Update where sweep
@eyonland
Copy link
Contributor Author

Closing this issue given that we are tracking the progress of the fixes through #13521

ct-clmsn pushed a commit to ct-clmsn/tt-metal that referenced this issue Nov 12, 2024
@VirdhatchaniKN
tenstorrent#13373: PyTorch Tracing Sweeps - Eltwise set 2 (tenstorren…
005eecb 
…t#13421)

* tenstorrent#13373: PyTorch Tracing Sweeps for set 2

* tenstorrent#13373: Update golden function

* tenstorrent#13421: Update

* tenstorrent#13421: Update where sweep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KalaivaniMCW KalaivaniMCW

Labels
master MCW op_cat: eltwise P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eyonland @VirdhatchaniKN @KalaivaniMCW