Pass explicit platforms list when publishing images #4480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
tekton-robot
added
the
size/XS
Prior to this commit the pipeline-release Pipeline relied on default params to ensure that the publish-release task emits a windows entrypoint image. It looks like this no longer works because the dogfooding cluster is using alpha API fields, including implicit params. With implicit params it is not possible to _skip_ a param in a PipelineTask if it shares a name with a Param in the Pipeline. So before we were intentionally omitting the platforms param and relying on the default param value in the publish-release Task but with implicit params this is no longer possible. This commit overrides the param passed to publish-release with the full string of platforms including windows. We don't want to update the Pipeline's `platforms` param because our build-images PipelineTask can't build the windows image. Confusing.
tekton-robot
added
size/S
dibyom
approved these changes
Jan 13, 2022
tekton-robot
added
the
approved
yeah, maybe we can have explicit build-platforms and publish-platforms |
imjasonh
reviewed
Jan 13, 2022
| # pipeline. The reason for this is that the build-images | ||
| # PipelineTask doesn't build the windows base image, but the | ||
| # publish-release PipelineTask does. | ||
| value: linux/amd64,linux/arm,linux/arm64,linux/s390x,linux/ppc64le,windows/amd64 |
There was a problem hiding this comment.
I wonder if we would benefit from value: $(params.platforms),windows/amd64
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, imjasonh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ghost
mentioned this pull request
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Prior to this commit the pipeline-release Pipeline relied on default
params to ensure that the publish-release task emits a windows
entrypoint image. It looks like this no longer works because the
dogfooding cluster is using alpha API fields, including implicit params.
With implicit params it is not possible to skip a param in a PipelineTask if it
shares a name with a Param in the Pipeline. So before we were intentionally omitting the
platforms param and relying on the default param value in the
publish-release Task but with implicit params this is no longer
possible.
This commit overrides the param passed to publish-release with the full
string of platforms including windows. We don't want to update the
Pipeline's
platformsparam because our build-imagesPipelineTask can't build the windows image. Confusing.
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes