Separate buildPlatforms and publishPlatforms #4486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit we passed different platform strings to the build phase and publish phase of our release pipeline. This commit creates two separately-named params just to make things a bit clearer for release captains that there are indeed two distinct uses for the platforms lists. As part of this commit I also noticed that we were using params directly in some script bodies, so took this opportunity to pull those out into env vars as well.
tekton-robot
added
release-note-none
tekton-robot
added
the
size/M
vdemeester
approved these changes
Jan 14, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
Thanks for doing this! Much nicer. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Prior to this commit we passed different platform strings to
the build phase and publish phase of our release pipeline.
This commit creates two separately-named params just to make things a
bit clearer for release captains that there are indeed two distinct uses
for the platforms lists.
(Edit: full credit to @dibyom for suggesting this change here)
As part of this commit I also noticed that we were using params directly
in some script bodies, so took this opportunity to pull those out into
env vars as well.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes
/kind misc