Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass explicit platforms list when publishing images #4480

Merged
merged 1 commit into from Jan 13, 2022
Merged

Pass explicit platforms list when publishing images #4480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions tekton/release-pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,13 @@ spec:
value: $(params.releaseAsLatest)
- name: serviceAccountPath
value: $(params.serviceAccountPath)
# NOTE: We're purposefully *not* passing the pipeline's platforms to
# this task. We want to use the task's default platforms, which include
# windows.
- name: platforms
# Important: This param value includes windows, which differs
# from the platforms param defined at the top of this release
# pipeline. The reason for this is that the build-images
# PipelineTask doesn't build the windows base image, but the
# publish-release PipelineTask does.
value: linux/amd64,linux/arm,linux/arm64,linux/s390x,linux/ppc64le,windows/amd64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we would benefit from value: $(params.platforms),windows/amd64

workspaces:
- name: source
workspace: workarea
Expand Down