Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass explicit platforms list when publishing images #4480

Merged
merged 1 commit into from Jan 13, 2022
Merged

Pass explicit platforms list when publishing images #4480

merged 1 commit into from Jan 13, 2022

Commits on Jan 13, 2022

  1. Pass explicit platforms list when publishing images 

    Prior to this commit the pipeline-release Pipeline relied on default
params to ensure that the publish-release task emits a windows
entrypoint image. It looks like this no longer works because the
dogfooding cluster is using alpha API fields, including implicit params.

With implicit params it is not possible to _skip_ a param in a PipelineTask if it
shares a name with a Param in the Pipeline. So before we were intentionally omitting the
platforms param and relying on the default param value in the
publish-release Task but with implicit params this is no longer
possible.

This commit overrides the param passed to publish-release with the full
string of platforms including windows. We don't want to update the
Pipeline's `platforms` param because our build-images
PipelineTask can't build the windows image. Confusing.
    Scott committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    fca09da View commit details
    Browse the repository at this point in the history