chore(components-angular): rename package to intranet-header-workspace #2072
Conversation
oliverschuerch
requested review from
b1aserlu,
davidritter-dotcom and
a team
as code owners
|
oliverschuerch
requested review from
gfellerph
and removed request for
imagoiq
|
Preview environment ready: https://preview-2072--swisspost-web-frontend.netlify.app |
# Conflicts: # pnpm-lock.yaml
…ent-angular package
# Conflicts: # packages/demo/package.json # packages/intranet-header-workspace/package.json # packages/intranet-header-workspace/projects/intranet-header/package.json # pnpm-lock.yaml
| @@ -15,7 +15,7 @@ name: Build Demo App | |||
| on: | |||
| pull_request: | |||
| paths: | |||
| - 'packages/components-angular/**' | |||
| - 'packages/intranet-header-workspace/**' | |||
There was a problem hiding this comment.
Why add the suffix -workspace?
There was a problem hiding this comment.
Because this package IS actually an angular-workspace: https://angular.io/guide/file-structure.
And the actual package, which is gonna be released, is inside of this workspace: intranet-header-workspace/projects/intranet-header
Co-authored-by: Loïc Fürhoff <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
#2072 introduces some sub-dependencies changes similarly to the initial PR of this revert: #2083. This breaks e2e tests for components and internet-header. `*.entry.js` files are not generated/copied to the documentation assets folder and creates a 404 when we try to use a web component. For testing, I cherry-pick the commit of this PR to #2140 Also upgrading to Stencil 4 (#2116) does not fix this issue.
This is necessary to make room for the up coming
components-angularpackage, generated out of thecomponentspackage.