chore(components, internet-header): 2080 Upgrade to Stencil 4 #2116

imagoiq · 2023-10-24T07:58:09Z

Fixes #2080

changeset-bot · 2023-10-24T07:58:13Z

🦋 Changeset detected

Latest commit: 8504810

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@swisspost/internet-header	Major
@swisspost/design-system-components	Major
@swisspost/design-system-documentation	Patch
@swisspost/design-system-components-react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

# Conflicts: # packages/components/package.json # packages/internet-header/package.json

swisspost-bot · 2023-10-25T08:14:16Z

Preview environment ready: https://preview-2116--swisspost-design-system-next.netlify.app

imagoiq · 2023-10-25T08:47:30Z

packages/components/src/components.d.ts

+    interface HTMLPostAlertElementEventMap {
+        "dismissed": void;
+    }
    interface HTMLPostAlertElement extends Components.PostAlert, HTMLStencilElement {
+        addEventListener<K extends keyof HTMLPostAlertElementEventMap>(type: K, listener: (this: HTMLPostAlertElement, ev: PostAlertCustomEvent<HTMLPostAlertElementEventMap[K]>) => any, options?: boolean | AddEventListenerOptions): void;
+        addEventListener<K extends keyof DocumentEventMap>(type: K, listener: (this: Document, ev: DocumentEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
+        addEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
+        addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
+        removeEventListener<K extends keyof HTMLPostAlertElementEventMap>(type: K, listener: (this: HTMLPostAlertElement, ev: PostAlertCustomEvent<HTMLPostAlertElementEventMap[K]>) => any, options?: boolean | EventListenerOptions): void;
+        removeEventListener<K extends keyof DocumentEventMap>(type: K, listener: (this: Document, ev: DocumentEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
+        removeEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
+        removeEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | EventListenerOptions): void;


This is missing in the main branch. Not linked to the update

imagoiq · 2023-10-25T08:47:35Z

packages/components/src/components.d.ts

+    interface HTMLPostTabsElementEventMap {
+        "tabChange": HTMLPostTabPanelElement['name'];
+    }
    interface HTMLPostTabsElement extends Components.PostTabs, HTMLStencilElement {
+        addEventListener<K extends keyof HTMLPostTabsElementEventMap>(type: K, listener: (this: HTMLPostTabsElement, ev: PostTabsCustomEvent<HTMLPostTabsElementEventMap[K]>) => any, options?: boolean | AddEventListenerOptions): void;
+        addEventListener<K extends keyof DocumentEventMap>(type: K, listener: (this: Document, ev: DocumentEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
+        addEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
+        addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
+        removeEventListener<K extends keyof HTMLPostTabsElementEventMap>(type: K, listener: (this: HTMLPostTabsElement, ev: PostTabsCustomEvent<HTMLPostTabsElementEventMap[K]>) => any, options?: boolean | EventListenerOptions): void;
+        removeEventListener<K extends keyof DocumentEventMap>(type: K, listener: (this: Document, ev: DocumentEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
+        removeEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
+        removeEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | EventListenerOptions): void;


This is missing in the main branch. Not linked to the update

imagoiq · 2023-10-25T08:47:49Z

packages/components/tsconfig.json

    "moduleResolution": "node",
    "module": "esnext",
    "target": "es2017",
    "noUnusedLocals": true,
    "noUnusedParameters": true,
    "jsx": "react",
    "jsxFactory": "h",
-    "resolveJsonModule": true
+    "resolveJsonModule": true,
+    "skipLibCheck": true


Only real change

imagoiq · 2023-10-25T08:48:03Z

packages/internet-header/src/components.d.ts

+        removeEventListener<K extends keyof HTMLSwisspostInternetHeaderElementEventMap>(type: K, listener: (this: HTMLSwisspostInternetHeaderElement, ev: SwisspostInternetHeaderCustomEvent<HTMLSwisspostInternetHeaderElementEventMap[K]>) => any, options?: boolean | EventListenerOptions): void;
+        removeEventListener<K extends keyof DocumentEventMap>(type: K, listener: (this: Document, ev: DocumentEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
+        removeEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
+        removeEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | EventListenerOptions): void;


This is missing in the main branch. Not linked to the update

imagoiq · 2023-10-25T08:49:04Z

@oliverschuerch It's actually already ready for review

#2072 introduces some sub-dependencies changes similarly to the initial PR of this revert: #2083. This breaks e2e tests for components and internet-header. `*.entry.js` files are not generated/copied to the documentation assets folder and creates a 404 when we try to use a web component. For testing, I cherry-pick the commit of this PR to #2140 Also upgrading to Stencil 4 (#2116) does not fix this issue.

sonarqubecloud · 2023-10-31T07:40:38Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

@oliverschuerch

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @swisspost/[email protected] ### Minor Changes - Added component exports to the src/index.ts files, to include them in the dist/index.js and dist/index.esm.js output files and therefore fix our stencil setup. (by [@oliverschuerch](https://github.com/oliverschuerch) with [`f74c9662`](f74c966)) - Added a `post-collapsible` event emitted when the collapse element is shown or hidden. (by [@alizedebray](https://github.com/alizedebray) with [#2079](#2079)) - Added the `post-accordion` component. (by [@alizedebray](https://github.com/alizedebray) with [#2079](#2079)) ### Patch Changes - Upgraded builder Stenciljs from version 3 to 4. No user visible changes are expected. (by [@imagoiq](https://github.com/imagoiq) with [#2116](#2116)) - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Minor Changes - Added component exports to the src/index.ts files, to include them in the dist/index.js and dist/index.esm.js output files and therefore fix our stencil setup. (by [@oliverschuerch](https://github.com/oliverschuerch) with [`f74c9662`](f74c966)) ### Patch Changes - Added logout-url property to override the URL provided by the portal config on the internet-header component. (by [@imagoiq](https://github.com/imagoiq) with [#2114](#2114)) - Upgraded builder Stenciljs from version 3 to 4. No user visible changes are expected. (by [@imagoiq](https://github.com/imagoiq) with [#2116](#2116)) - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated icons number 8000. (by [@swisspost-bot](https://github.com/swisspost-bot) with [#2151](#2151)) ## @swisspost/[email protected] ### Patch Changes - Fixed default user image sometimes blocked by CORS policies. (by [@alizedebray](https://github.com/alizedebray) with [#2165](#2165)) - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Changed dropdown icon for the select component and adjusted the size of the icon. (by [@b1aserlu](https://github.com/b1aserlu) with [#2164](#2164)) - Added `table-mono` variant for table component. (by [@imagoiq](https://github.com/imagoiq) with [#2106](#2106)) - Set a `max-width` for badges and add ellipsis for overflowing text. (by [@davidritter-dotcom](https://github.com/davidritter-dotcom) with [#1892](#1892)) - Applied autoprefixer to distributed sass files. Sass files will now contain prefixes for supported browsers according to the browserslist file. (by [@imagoiq](https://github.com/imagoiq) with [#2115](#2115)) ## @swisspost/[email protected] ### Minor Changes - Used the new tabs to improve the presentation of some code snippets. (by [@b1aserlu](https://github.com/b1aserlu) with [#2130](#2130)) - Added the `post-accordion` component. (by [@alizedebray](https://github.com/alizedebray) with [#2079](#2079)) - Added a new documentation for sizing. (by [@b1aserlu](https://github.com/b1aserlu) with [#2028](#2028)) ### Patch Changes - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

chore(components, internet-header): 2080 Upgrade to Stencil 4

4d3dfa7

imagoiq self-assigned this Oct 24, 2023

imagoiq added 2 commits October 25, 2023 08:34

Merge branch 'main' into chore/2080-stencil-4

6d7dda2

# Conflicts: # packages/components/package.json # packages/internet-header/package.json

Fix pnpm lock

3521314

imagoiq marked this pull request as ready for review October 25, 2023 06:41

imagoiq requested a review from a team as a code owner October 25, 2023 06:41

imagoiq requested a review from oliverschuerch October 25, 2023 06:41

imagoiq added 4 commits October 25, 2023 08:48

Empty-Commit

d3dc5b2

Reinstall

115a424

Fix pnpm lock

fb4f43c

Typescript skipLibCheck

ede63a1

imagoiq commented Oct 25, 2023

View reviewed changes

Merge branch 'main' into chore/2080-stencil-4

840f148

imagoiq mentioned this pull request Oct 30, 2023

fix(e2e): Revert vite 4.11 upgrade #2160

Merged

Merge branch 'main' into chore/2080-stencil-4

8504810

oliverschuerch approved these changes Oct 31, 2023

View reviewed changes

imagoiq merged commit 6446161 into main Oct 31, 2023
7 checks passed

imagoiq deleted the chore/2080-stencil-4 branch October 31, 2023 10:07

github-actions bot mentioned this pull request Oct 31, 2023

chore(changesets): 🦋📦 publish packages #2124

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(components, internet-header): 2080 Upgrade to Stencil 4 #2116

chore(components, internet-header): 2080 Upgrade to Stencil 4 #2116

imagoiq commented Oct 24, 2023 •

edited

Loading

changeset-bot bot commented Oct 24, 2023 •

edited

Loading

swisspost-bot commented Oct 25, 2023 •

edited

Loading

imagoiq Oct 25, 2023

imagoiq Oct 25, 2023

imagoiq Oct 25, 2023

imagoiq Oct 25, 2023

imagoiq commented Oct 25, 2023

sonarqubecloud bot commented Oct 31, 2023

chore(components, internet-header): 2080 Upgrade to Stencil 4 #2116

chore(components, internet-header): 2080 Upgrade to Stencil 4 #2116

Conversation

imagoiq commented Oct 24, 2023 • edited Loading

changeset-bot bot commented Oct 24, 2023 • edited Loading

🦋 Changeset detected

swisspost-bot commented Oct 25, 2023 • edited Loading

imagoiq Oct 25, 2023

Choose a reason for hiding this comment

imagoiq Oct 25, 2023

Choose a reason for hiding this comment

imagoiq Oct 25, 2023

Choose a reason for hiding this comment

imagoiq Oct 25, 2023

Choose a reason for hiding this comment

imagoiq commented Oct 25, 2023

sonarqubecloud bot commented Oct 31, 2023

imagoiq commented Oct 24, 2023 •

edited

Loading

changeset-bot bot commented Oct 24, 2023 •

edited

Loading

swisspost-bot commented Oct 25, 2023 •

edited

Loading