chore(*): Fix eslint configs #2140
Conversation
|
|
Preview environment ready: https://preview-2140--swisspost-web-frontend.netlify.app |
| parserOptions: { | ||
| ecmaVersion: 'latest', | ||
| sourceType: 'module', | ||
| tsconfigRootDir: __dirname, |
There was a problem hiding this comment.
Convert to js to be able to use __dirname
#2072 introduces some sub-dependencies changes similarly to the initial PR of this revert: #2083. This breaks e2e tests for components and internet-header. `*.entry.js` files are not generated/copied to the documentation assets folder and creates a 404 when we try to use a web component. For testing, I cherry-pick the commit of this PR to #2140 Also upgrading to Stencil 4 (#2116) does not fix this issue.
| @@ -0,0 +1,77 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
I got an error that this file can be converted to an es module (the automatic migration does not work, but export default works for me)
| module.exports = { | |
| export default { |
There was a problem hiding this comment.
Unfortunately, it's not as easy as that. I think the error only appears in your IDE, but not the tools. We need to make a lot of changes so I created another ticket for that: #2167
| "exclude": [ | ||
| "node_modules" | ||
| ] | ||
| "include": ["src", "**/tests"], |
There was a problem hiding this comment.
Another error says that the eslint config file is not linted.
| "include": ["src", "**/tests"], | |
| "include": ["src", ".eslintrc.js", "**/tests"], |
There was a problem hiding this comment.
I cannot reproduce it. Where does the error appear?
There was a problem hiding this comment.
It only appears when the above suggestion is applied, so it will be fixed with #2167
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.