Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(components-angular): rename package to intranet-header-workspace #2072

Merged
merged 8 commits into from
Oct 25, 2023
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-demo.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ name: Build Demo App
on:
pull_request:
paths:
- 'packages/components-angular/**'
- 'packages/intranet-header-workspace/**'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add the suffix -workspace?

Copy link
Contributor Author

@oliverschuerch oliverschuerch Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this package IS actually an angular-workspace: https://angular.io/guide/file-structure.
And the actual package, which is gonna be released, is inside of this workspace: intranet-header-workspace/projects/intranet-header

- 'packages/demo/**'
- 'packages/styles/src/**'
- 'packages/styles/*'
Expand Down
2 changes: 1 addition & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
// Fixes tsconfig not found error in nested .eslintrc.json files with relative paths
"eslint.workingDirectories": ["packages/components-angular"]
"eslint.workingDirectories": ["packages/intranet-header-workspace"]
}
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ These contribution guidelines apply to this repository in general and describe h

- [Angular Demo](./packages/demo/README.md)
- [Design System Styles](./packages/styles/CONTRIBUTING.md)
- [Angular Components (Intranet Header)](./packages/components-angular/projects/intranet-header/CONTRIBUTING.md)
- [Angular Components (Intranet Header)](./packages/intranet-header-workspace/projects/intranet-header/CONTRIBUTING.md)
oliverschuerch marked this conversation as resolved.
Show resolved Hide resolved

## Prerequisites

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ npm install @swisspost/internet-header

[![npm](https://img.shields.io/npm/v/@swisspost/design-system-intranet-header)](https://www.npmjs.com/package/@swisspost/design-system-intranet-header)

[Documentation](https://design-system.post.ch/#/post-samples/intranet-layout) · [Changelog](/packages/components-angular/CHANGELOG.md)
[Documentation](https://design-system.post.ch/#/post-samples/intranet-layout) · [Changelog](/packages/intranet-header-workspace/CHANGELOG.md)

The Header Angular component for internal usage.

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"components:e2e": "start-server-and-test docs:headless 9300 'pnpm --filter design-system-components e2e'",
"components:e2e:watch": "start-server-and-test docs:headless 9300 'pnpm --filter design-system-components e2e:watch'",
"components:snapshots": "start-server-and-test docs:headless 9300 'pnpm --filter design-system-components snapshots'",
"intranet-header:start": "pnpm --filter design-system-components-angular start",
"intranet-header:start": "pnpm --filter design-system-intranet-header-workspace start",
"header:start": "pnpm --filter internet-header dev",
"header:build": "pnpm --filter internet-header build",
"header:test": "pnpm --filter internet-header test",
Expand Down
2 changes: 1 addition & 1 deletion packages/documentation/src/stories/home.docs.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import './home.styles.scss';
</Tile>
<Tile
title="Intranet-Header"
href="https://github.com/swisspost/design-system/tree/main/packages/components-angular/projects/intranet-header"
href="https://github.com/swisspost/design-system/tree/main/packages/intranet-header-workspace/projects/intranet-header"
>
<img
src="/images/packages/intranet-header.svg"
Expand Down
2 changes: 1 addition & 1 deletion packages/documentation/src/utils/version.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {
} from '@swisspost/design-system-styles/package.json';
import { version as components } from '@swisspost/design-system-components/package.json';
import { version as internetheader } from '@swisspost/internet-header/package.json';
import { version as intranetheader } from './../../../components-angular/projects/intranet-header/package.json';
import { version as intranetheader } from './../../../intranet-header-workspace/projects/intranet-header/package.json';
import { version as icons } from '@swisspost/design-system-icons/package.json';
import { version as documentation } from './../../package.json';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
# @swisspost/design-system-components-angular
# @swisspost/design-system-intranet-header-workspace

## 3.0.2

### Patch Changes

- Updated dependencies:
- @swisspost/[email protected]

## 3.0.2

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "@swisspost/design-system-components-angular",
"name": "@swisspost/design-system-intranet-header-workspace",
"version": "3.0.2",
"license": "Apache-2.0",
"private": true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ These contribution guidelines extend the [general contribution guidelines](../..

**Attention**: When running commands from the design-system root folder, you'd need to prefix your `ng` commands with

`pnpm --filter design-system-components-angular exec ng ...`
`pnpm --filter design-system-intranet-header-workspace exec ng ...`

Alternatively, you can `cd packages/components-angular` and run commands from this location without prefix.
Alternatively, you can `cd packages/intranet-header-workspace` and run commands from this location without prefix.

Run `ng generate component component-name --project intranet-header` to generate a new component. You can also use `ng generate directive|pipe|service|class|guard|interface|enum|module --project intranet-header`.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@
"tslib": "2.6.2"
},
"devDependencies": {
"@swisspost/design-system-components-angular": "workspace:3.0.2"
"@swisspost/design-system-intranet-header-workspace": "workspace:3.0.2"
}
}
Loading
Loading