Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cumulative fixes and zoomable ui #92

Merged
merged 100 commits into from
Dec 18, 2018
Merged

Cumulative fixes and zoomable ui #92

merged 100 commits into from
Dec 18, 2018

Conversation

kzantow
Copy link
Collaborator

@kzantow kzantow commented Dec 16, 2018

This may subsume #68 #69 #87 and other fixes/enhancements including a zoomable UI for AU

@baconpaul @esaruoho please have a look

baconpaul and others added 30 commits December 10, 2018 07:59
see it try to grab the carbon UI in a printf!
crashes Logic on Exit. So not exactly awesome but at least I have
plumbed through to an NSView even if I have my ownership wrong
… low in the classes compared to VST. Checkpoint so I can look at params
Moved all References to the bottom of the file
Beautification of premake5 while adding audiounit.framework
Google Translate + Human translate of Swedish into English. Content accuracy is debatable.
google+human translate swedish-english
simultainously -> simultaneously
@esaruoho
Copy link
Collaborator

@baconpaul you might wanna add surge-vst2.xcodeproj/ to that list of disable deprecation and override warnings? :)

@baconpaul
Copy link
Collaborator

There you go @esaruoho!

@esaruoho
Copy link
Collaborator

cool! now how do we find @kurasu and @abique :)

@kzantow
Copy link
Collaborator Author

kzantow commented Dec 18, 2018

@baconpaul could you point me to the pertinent parts of making zoom work?

@baconpaul
Copy link
Collaborator

@baconpaul could you point me to the pertinent parts of making zoom work?

https://github.com/kurasu/surge/issues/81 has the details of how I did it. Basically if you are in a non-AU host you need to implement and register a zoom callback which scales, and you need to make sure the SurgeGUIEditor code which puts in the +/- button inside an #if TARGET_AUDIOUNIT is on for you also.

@esaruoho
Copy link
Collaborator

I've reached out to @kurasu over KVR-audio, here's hoping he reads them. Not sure how else to reach out to him. I've tweeted to bitwig on twitter, too, asking if Claes or @abique might have the time to look at this PR .. or appoint someone who might have time to look at PRs..

@kurasu
Copy link
Collaborator

kurasu commented Dec 18, 2018

Ok, I've read through the code, seems fine.. Will do a quick build/test round before merging it in..

Thanks guys!

@kurasu kurasu merged commit fa85b05 into surge-synthesizer:master Dec 18, 2018
@baconpaul
Copy link
Collaborator

Thank you so much! I’ll pull and close issues and stuff later on today.

@esaruoho
Copy link
Collaborator

@kzantow should we keep housecleaning by deleting this branch? :)

@kzantow
Copy link
Collaborator Author

kzantow commented Dec 18, 2018

@esaruoho yessir (although the branch is just on my fork)

@kzantow kzantow deleted the cumulative-fixes-and-zoomable-ui branch December 18, 2018 18:45
@baconpaul
Copy link
Collaborator

And yeah I have confirmed the merge is perfect and master runs with all the diffs. Good work folks!

@kzantow
Copy link
Collaborator Author

kzantow commented Dec 18, 2018

Mostly your doing @baconpaul , but a combined effort for testing and other small issues. I'm just glad to help move this synth forward, I'd not even used it before getting it running built by myself, pretty amazed at how flexible it is. @kurasu did an amazing job!

baconpaul pushed a commit to baconpaul/surge that referenced this pull request Jul 10, 2019
…-and-zoomable-ui

Cumulative fixes and zoomable ui

Former-commit-id: fa85b05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants