Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate comments from Swedish to English #67

Closed
esaruoho opened this issue Dec 12, 2018 · 10 comments
Closed

Translate comments from Swedish to English #67

esaruoho opened this issue Dec 12, 2018 · 10 comments

Comments

@esaruoho
Copy link
Collaborator

esaruoho commented Dec 12, 2018

As @kurasu warned, a couple of comments were in Swedish. So I translated them to English, with Google Translate, some work by hand, and a lot of help by a friend.

Check the PR at #68

@baconpaul
Copy link
Collaborator

This translation would be super useful!

@esaruoho
Copy link
Collaborator Author

@baconpaul i'm working on it.. i've got a branch in my fork

@baconpaul
Copy link
Collaborator

Thank you! A good week here - we went from a million compiler errors to a sorta working ui. Been fun hacking through it with you!

@esaruoho
Copy link
Collaborator Author

geez i don't know how to find all the ISO-8859-1 encoded files. i'm gonna make this into a PR and see..

@esaruoho
Copy link
Collaborator Author

@baconpaul here's a start of translations, #68

I need to figure out some magick on OSX to find which files are encoded in ISO-8859-1 so I can find @kurasu 's Swedish language comments. I'll do that tomorrow. Hope this helps anyway.

@esaruoho
Copy link
Collaborator Author

if someone can help me figure out how to use

file -l on OSX recursively on the whole repo, that would really help.

@baconpaul
Copy link
Collaborator

find src -exec file -I {} \; | grep -v inode/directory | grep -v us-ascii

and that's -I (capital i) not -l (lower case L)

Attached output as a txt file

f.txt

@esaruoho
Copy link
Collaborator Author

thanks @baconpaul - that helped immensely. i'll check through the remainder of the files in the next few hours.

@esaruoho
Copy link
Collaborator Author

Thanks @baconpaul - I've now finished with the PR translations, so will tag it as one that closes this ticket.

@esaruoho esaruoho changed the title Translate comments in Swedish from Swedish to English Translate comments from Swedish to English Dec 15, 2018
@esaruoho
Copy link
Collaborator Author

Closed by #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants