Surge-VST3: (macOS) linker command failed with exit code 1 (use -v to see invocation) clang

[esaruoho]

After proceeding from making a tiny fix ( #79 ) - the next error while trying to get surge-vst3 built with macOS is:

linker command failed with exit code 1 (use -v to see invocation) clang

Now, I can't even click it so that xcode would suggest a fix. any ideas?

[baconpaul]

Linker errors usually mean you have an undefined symbol. Xcode makes it annoying to find them as far as I can see.

I simulated one in my local area just now

the trick I find to find the symbol is to go to the set of logs and find your failing build

then when you click on the little expanding hamburger glyph thing you see the symbols you are missing

Usually this occurs because you are including a .h file for a subset of a library but not building or linking the associated .cpp. Especially if you see something like Steinberg::VST::MyBlimBlom it probably means your include path allows you to #include "myblimblom" but you're premake5.lua doesn't include myblimblom.cpp

Hope this helps! Good luck.

[esaruoho]

Thanks for the assist! the error i'm seeing is..

[baconpaul]

Oh yeah So SurgeVSTEditController isn’t implemented it seems like. But it also isn’t used in the AU as far as I saw. I have an ifdef which comments it out for AU which was in my first get-it-running PR Is the object even used or is it just referenced? Seems like an awful lot to implement though. does grep -r show those implemnted anywhere in the source tree? (grep -r “foo” src/ vst3sdk/ is now built into my fingers!) On Dec 15, 2018, at 11:33 AM, Esa Juhani Ruoho <[email protected]<mailto:[email protected]>> wrote: Thanks for the assist! the error i'm seeing is.. [surge_xcworkspace]<https://user-images.githubusercontent.com/4966687/50045237-d67ba580-0097-11e9-8316-9515d5bce1c6.png> — You are receiving this because you commented. Reply to this email directly, view it on GitHub<https://github.com/kurasu/surge/issues/80#issuecomment-447580609>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AMxHKfb-2L6GqY3pffaSJ6QJ7xCRUCthks5u5SQ_gaJpZM4ZURqX>.

[asimilon]

I also see these link errors. Not entirely sure from looking at git blame history, so wondering who wrote in the README

You can also build a VST which links but honestly we aren't sure if it works. Help from someone who uses VST would be appreciated here!

I'm wondering how this is possible that it built and linked?

[baconpaul]

I had written that when it linked! I then got the au working and stopped looking at vst. And apparently now it is back to not linking :)

If it is the surgeditor symbol errors I fixed that by ifdefing out the class which wasn’t used. Later tonight I will take a peek and see what’s in head.

These sorts of problems will pop up more and more the longer our merge backlog is! I really hope we can get master back close to the codebase which runs the au soon.

[baconpaul]

Right this diff

https://github.com/kzantow/surge/commit/f20830627f7b0e6546b771ab2f087a537c9673ea

Which made it work. That if 0 went to if !target audio unit, though, which is why au works and vst no longer does

So to make vst work also exclude that class if it is truly not needed or finish those methods. With it excluded I could compile and link but not run a vst

[baconpaul]

Oh and that is my diff. Just I’m looking st it on kzantows big merge branch which is why his name shows up.

[asimilon]

Slightly unrelated, but on the VST2 project, with some excluding of AU specific files from premake5.lua I've got it successfully building and linking, however, it's not being recognised. Perhaps it's going to be similar issue for the VST3, will investigate.

[esaruoho]

@asimilon query -- what is not recognizing Surge.vst? Have you checked https://github.com/tracktion/pluginval to see what it says on the VST?

[baconpaul]

great! Happy to answer any questions about the au or look at any diffs if that helps

[baconpaul]

OK I figured out the premake thing that was breaking vat and how to change it so that AU still worked and have a diff coming which will allow VST3 and AU to link. Stay tuned. I'll push it to the big PR.

[baconpaul]

kurasu@ce3b57d

OK there's the diff. @asimilon if you want to use this you need to fetch and merge @kzantow branch "cumulative-fixes-and-zoomable-ui"

I have not included your build.osx changes in that. Honestly it was too tricky to pull the commit from a fourth remote!

But with those changes, VST3 and AU both link if you start from a clean area and rerun premake

[baconpaul]

Oh and by being in cumulative-fixes-and-zoomable-ui it participates in the big PR which gets the AU running also.

I don't want to add a million things to that PR. If you actually can get the VST validating from there maybe a separate one makes sense but to do that one you will probably want to start from the cumulative-fixes branch.

[baconpaul]

Can we close this issue @esaruoho - It's now resolved after the #92 merge.

[esaruoho]

Closing ticket :)