Cocoa UI on MacOS in Audio Unit with Zoom, LFO display, and several other fixes.

[baconpaul]

Hi

This diff is the PR we need to build and correctly run the gui on MacOS. Nowhere near as big as the one to get the synth running, but quite a lot harder, mostly because I'm not really a cocoa expert and the documentation on the internet just sorta stinks. But I figured it out eventually and here we go.

The discussion of this is in #61

Thanks to @esaruoho for feedback and stuff.

Once this is done, I think the only step left to actually being able to do a 64 bit audio unit mac release of surge is making a packager rather than the hack job scripts I have together to build this now.

Appreciate any feedback, corrections, changes, concerns, or critiques.

[esaruoho]

You guys might appreciate this screenshot that @baconpaul attached into #61

[kzantow]

<3 @baconpaul

[esaruoho]

This really works and is a serious serious improvement, finally being able to see Surge on Logic Pro X and actually program it a little bit. @kurasu and @abique might have some insider knowledge as to what is missing or what doesn't work, but I'm able to load presets, program my own and whatever.

There's probably tons yet to be fixed but this is a major step forward. I hope we'll get this merged in asap.

[esaruoho]

Confirmed (by a friend): Ableton Live 10 will run this AudioUnit without issues (well, obviously there might be some issues with Logic Pro X + Ableton Live 10 running this, further down the line, but the synth UI booted up and stuff.)

i'll see if I can get Renoise to show this somehow.
EDIT: I just can't get Renoise to show this.

[esaruoho]

can confirm, Surge works with Ableton Live 10. Hot stuff!

[baconpaul]

Wahey! That’s super!

[esaruoho]

@baconpaul not as fully as in logic, though, for some reason, i can't click on the dropdown menu that would let me choose an effect to add to the chain. it works in logic but not on ableton live. how odd..

EDIT: this issue I had was directly related to me not running

echo "INSTALLING PRESETS"
(cd resources/data && tar cf - . ) | ( cd ~/Library/Application\ Support/Surge && tar xf - )

from the installer_local_au.sh - instead just copying over the .component without also creating the preset/configuration folder in ~/Library/Application Support/Surge.

Once I did copy resources/data to ~/Library/Application Support/Surge, I was able to get full working state with a new computer running the Surge AudioUnit component.

[baconpaul]

Wonder if live is handling GUI events differently somehow? As i mentioned I’m logic on Mac only so don’t have a good way to debug differences in different hosts alas

[esaruoho]

@kurasu hi, would you have time to take a look and merge this in? It works beautifully - any other additions would be iterative updates (fixing the LFO Wave at the bottom, etc)..

[kzantow]

@baconpaul I've got the same issue with VST2 and AU that clicking the effect drop-down doesn't work, nor does the oscillator type selector (I'm guessing the "CLASSIC ▼" bit is this). I don't have logic, but based on latest master + this branch, it's reproducible in REAPER and AU Lab. I'm happy to debug this, but not quite sure where to start.

UPDATE: I figured this out to be the inability to find the configuration.xml and made a bit of a PR with a fix: #87

[esaruoho]

@kzantow @baconpaul hi, i narrowed down the "clicking on dropdown menus or changing presets or creating effect chains doesn't work in Live/Logic on another computer" issue to the old resources/data copying to ~/Library/Application Support/Surge <- once that's done,both the VST2 and AudioUnit will work on Ableton Live 10 and Logic Pro X.

I still can't get the AudioUnit to show on Renoise, though. This might be an issue with Renoise.

[baconpaul]

OK @esaruoho and @kzantow I just merged both zoomable-ui and the fix for the right mouse button into au-cocoaui-build so this pull request now gets me to fixing

#89 (broken install popup)
#83 (no LFO waveform)
#81 (fix zoom in surge)
#61 (create the cocoa ui)

I think it would be great if we could also include @kzantow std::filesystem fix and the documentation at least. Do you guys have permission to add those to this PR? And if not, how do I grant it to you?

[esaruoho]

@baconpaul i don't have a way to write to your PR, and i'm not sure how to contribute to it.. except to maybe post a PR to your fork and you merge it into this.. but for now i'll probably try and see if @kurasu will merge #68 in and then i'll delete my fork, re-create it and hope it works better.

[baconpaul]

OK but doesn't #68 contain that weird memory diff we were talking about?

Anyway lets see what gets merged!

[esaruoho]

@baconpaul yeah it has the "merge from kurasu:master to esaruoho:master" diff.. i'm yet to figure out how to revert it out of it.

[baconpaul]

OK thanks to @kzantow who is marshaling together all the changes that he did, that I did and that @esaruoho did into one pull request #92. I have confirmed that PR #92 subsumes this code, and also adds a fix, and so is the better PR than this one to review. As such I'm closing this one.