Wavetable right click menu doesn't work

[really-need-an-api-key]

Describe the bug
No context menu (containing all the wavetables for easy selection) is shown when right-clicking the wavetable name.

To Reproduce
Steps to reproduce the behavior:

1. Right-click on the wavetable name.

Expected behavior
Right clicking the wavetable name should open a context menu with all the wavetables.

Desktop (please complete the following information):

• OS: Windows 7
• Host: FL Studio 12
• Version: 12.0.5

Additional context
Context menu doesn't work in VSTHost either. Switching via the tiny arrows works though.

[esaruoho]

@really-need-an-api-key hi, could ya take a screenshot showing where you click where it should load up a "loader / file browser" screen, please?

[baconpaul]

This is literally a one line change. Looks like the rewrite of the context menu just forgot to call popup

I have fixed it in

baconpaul@d404bdd

but I can't send a pull request for that until #69 is merged

[baconpaul]

Oh that "." and ".." is because the mac stub of std::filesystem implements

[baconpaul]

sorry because std::filesystem implements the iterator wrong so I have a new issue for that in #77

[esaruoho]

This is literally a one line change. Looks like the rewrite of the context menu just forgot to call popup
I have fixed it in
baconpaul@d404bdd
but I can't send a pull request for that until #69 is merged

@baconpaul can this one-line fix be added into #69 ?

[baconpaul]

Oh sure I guess it could! But since this may also impact VST I sort of left it aside.

Also, my local dev area is a bit of a mess right now because I'm working on a zoomable UI so let me keep my brain there for now.

[esaruoho]

@baconpaul well, i'm trying to work through the scraps out there re: macOS VST2 - found this one by @asimilon ( https://github.com/asimilon/surge/tree/macOS_VST2_build ) and am hoping that it'll somehow tide me over into an actual VST2 version. not entirely sure, of course!

[baconpaul]

Yeah I really don’t use vst at all - I’m 100% Logic Pro, lilypond, and hand rolled software. What’s the best Mac free vst host to try on?

[asimilon]

Not sure if it's the best, but it fits the "free" criteria : https://www.tracktion.com/products/t7-daw

[baconpaul]

Yeah best is definitely an opinion! Also we all know emacs is the best. We just need M-x daw-mode to get finished.

Thanks!

[esaruoho]

@baconpaul i added your fix to this into my larger PR #68 . hope that's fine

[baconpaul]

Sure!

[esaruoho]

👍