Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS VST2/AU: enable right-clicking on wavetable to get dropdown menu #724

Closed
esaruoho opened this issue Mar 5, 2019 · 2 comments · Fixed by #741
Closed

macOS VST2/AU: enable right-clicking on wavetable to get dropdown menu #724

esaruoho opened this issue Mar 5, 2019 · 2 comments · Fixed by #741
Milestone

Comments

@esaruoho
Copy link
Collaborator

esaruoho commented Mar 5, 2019

currently if you click on the wavetable name with left-mouse button, you get the list.
but if you click on the wavetable name with right-mouse button, nothing happens.

i propose: make right-mousebutton also show the list.

this was spoken about at #29 and seems like it was forgotten. so, i'm gonna look at what baconpaul did and make a PR out of it.

tried to PR #723
dunno if i'm doing it right :)

@esaruoho
Copy link
Collaborator Author

esaruoho commented Mar 5, 2019

#723 didn't make it happen either, closing the PR

@baconpaul baconpaul added this to the 1.6.0 milestone Mar 5, 2019
@baconpaul
Copy link
Collaborator

@esaruoho if you want to do this change

CMouseEventResult COscillatorDisplay::onMouseDown(CPoint& where, const CButtonState& button)
{
   if (!(button & kLButton))
      return kMouseDownEventHandledButDontNeedMovedOrUpEvents;

to

CMouseEventResult COscillatorDisplay::onMouseDown(CPoint& where, const CButtonState& button)
{
   if (! ( (button & kLButton) || (button & kRButton ) )
      return kMouseDownEventHandledButDontNeedMovedOrUpEvents;

and it should just all work.

baconpaul pushed a commit that referenced this issue Mar 7, 2019
Closes  #724
objective: make right-mouse-button clicking open WaveTable Context menu too!
baconpaul pushed a commit to baconpaul/surge that referenced this issue Jul 10, 2019
Closes  surge-synthesizer#724
objective: make right-mouse-button clicking open WaveTable Context menu too!
Former-commit-id: 7045d1910081df40e9253741870440b72f71f2f2 [formerly 9e58f17]
Former-commit-id: c5686e7831278409e17cb69230c62484399d3a23
Former-commit-id: ec3d0628532a08866ab4ca8af40b27190e07db34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants