Factor test data out of test module #1
Conversation
|
Hey, this is a great refactor, thanks! It can't be merged as-is due to a conflict, and also because the |
|
Great! Thanks! Will that be here: https://github.com/str4d/librustzcash/tree/zcash-transaction-primitives ? I have two other things to commit, and I'd like to PR them against the most convenient branch. |
|
Ahh.. you mean you prefer each |
|
@str4d , I will refactor again on top of your latest, with the |
|
When you say the TestVector struct needs to be semantically separated, do you mean you want a separate struct for each test? |
|
OK @str4d I refactored atop your latest, to remove the need for a cherry-pick. I'm not exactly clear on whether the |
Migrate curve traits and tests, and WNAF, from pairing
Co-authored-by: Jack Grigg <[email protected]>
This crate exposes both the ChaCha20Poly1305 IETF construction, and the underlying ChaCha20 IETF primitive, removing the need for depending on our own fork of the previous chacha20-poly1305-aead crate.
The crypto_api_chachapoly uses two new features introduced in 1.32: - Self struct constructors - u64::to_le_bytes()
Use wrapping function to directly disable integer overflow protection.
Place bellman multicore operations behind a (default) feature flag
Electric Coin Company
Closes zcash#52. Fix test error "attempt to shift right with overflow".
Release 0.1.0
This enables basic verification of chain validity when CompactBlocks are received without the full header.
Checking for spent notes in a block is still not completely constant time, due to filtering out negative results of the constant-time comparison. Part of zcash#84.
cargo fmt does not build the code, and running it in a fresh clone of the codebase will fail because the protobuf code has not been generated.
cargo fmt does not build the code, and running it in a fresh clone of the codebase will fail because the protobuf code has not been generated.
CompactBlock parsing and scanning
|
The branch this PR is targeting was merged upstream in zcash#39, so this PR should probably be closed here and rebased / recreated on upstream master. |
|
I'll put this on the TODO list. |
|
I notice automated tests run when I update the PR against the @str4d fork. I'll let them run, before possibly closing and re-opening against origin. |
|
Alright, all checks passed.... closing an reopening against origin/master. |
ZIP-225/244 #1: Minor refactoring and preparatory updates.
I renamed
tests.rstotests/mod.rsfor reasons I am not entirely clear on this made it easier to usemodnamespaces to organize test data.Organizing test data was my primary motivation for this work. I wanted to be able to easily read the test code in the
first-tests-later-mod.rsfile. This solution worked for me.While I was hacking this out @str4d (who was unaware I was poking about) updated the test data.. I add his update with a commit message pointing to the original commit.