Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test? #52

Closed
dusty-phillips opened this issue Dec 17, 2018 · 1 comment
Closed

Failing test? #52

dusty-phillips opened this issue Dec 17, 2018 · 1 comment
Labels
E-good-first-issue Effort: Suitable for someone new to the codebase. testing

Comments

@dusty-phillips
Copy link

I'm getting a test failure when running cargo test uint32_shr. Is this normal/expected, or do I have something odd in my configuration?

Here's the tail end of the traceback:

   7: core::panicking::panic_fmt
             at libcore/panicking.rs:77
   8: core::panicking::panic
             at libcore/panicking.rs:52
   9: sapling_crypto::circuit::uint32::test::test_uint32_shr
             at sapling-crypto/src/circuit/uint32.rs:631
  10: sapling_crypto::__test::TESTS::{{closure}}
             at sapling-crypto/src/circuit/uint32.rs:624
  11: core::ops::function::FnOnce::call_once
             at /checkout/src/libcore/ops/function.rs:223
  12: <F as alloc::boxed::FnBox<A>>::call_box
             at libtest/lib.rs:1451
             at /checkout/src/libcore/ops/function.rs:223
             at /checkout/src/liballoc/boxed.rs:642
  13: __rust_maybe_catch_panic
             at libpanic_unwind/lib.rs:105

Some specs:

  • rustc 1.29.2 (17a9dc751 2018-10-05)
  • cargo 1.29.0 (524a578d7 2018-08-05)
  • Fedora 28
  • Linux Kernel 4.19.2
@ebfull
Copy link
Collaborator

ebfull commented Jan 3, 2019

Yeah, I need to use wrapping shifts in the test. It's just a bug in the test. I recommend running tests with --release anyway because otherwise I think they'll be incredibly slow.

@str4d str4d added the testing label Jan 15, 2019
@str4d str4d added the E-good-first-issue Effort: Suitable for someone new to the codebase. label Jan 30, 2019
@str4d str4d closed this as completed in 437b66d May 28, 2019
str4d added a commit that referenced this issue May 28, 2019
Closes #52. Fix test error "attempt to shift right with overflow".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-good-first-issue Effort: Suitable for someone new to the codebase. testing
Projects
None yet
Development

No branches or pull requests

3 participants