Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #52. Fix test error "attempt to shift right with overflow". #81

Merged
merged 1 commit into from
May 28, 2019

Conversation

bitcartel
Copy link
Contributor

Use wrapping function to directly disable integer overflow protection.

Use wrapping function to directly disable integer overflow protection.
@bitcartel bitcartel requested a review from ebfull May 17, 2019 04:02
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Ran the test and confirmed that the error is fixed.

Copy link
Contributor

@Eirik0 Eirik0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@str4d str4d merged commit 2d97ccb into zcash:master May 28, 2019
str4d pushed a commit to str4d/librustzcash that referenced this pull request Aug 5, 2019
Add must_use to operations over Edwards points
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants