Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZIP-225/244 #1: Minor refactoring and preparatory updates. #385

Merged
merged 6 commits into from
Jun 2, 2021

Conversation

nuttycom
Copy link
Contributor

This is a set of minor improvements to type safety factored out from #375.

@nuttycom nuttycom requested review from str4d and therealyingtong May 19, 2021 15:53
Copy link
Contributor

@therealyingtong therealyingtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@nuttycom nuttycom added this to the Core Sprint 2021-20 milestone May 25, 2021
@nuttycom nuttycom added the S-committed Status: Planned work in a sprint label May 25, 2021
@nuttycom nuttycom changed the title Minor refactoring and updates in preparation for ZIP 225 ZIP-255/244 #1: Minor refactoring and preparatory updates. May 26, 2021
@nuttycom nuttycom changed the title ZIP-255/244 #1: Minor refactoring and preparatory updates. ZIP-225/244 #1: Minor refactoring and preparatory updates. May 26, 2021
@nuttycom nuttycom force-pushed the feature/zip-225-prep branch 3 times, most recently from 8bb252d to 0f3f5b0 Compare May 26, 2021 18:02
zcash_primitives/src/consensus.rs Outdated Show resolved Hide resolved
zcash_primitives/src/sapling.rs Outdated Show resolved Hide resolved
zcash_client_backend/src/welding_rig.rs Outdated Show resolved Hide resolved
zcash_primitives/src/transaction/blake2b_256.rs Outdated Show resolved Hide resolved
@nuttycom nuttycom force-pushed the feature/zip-225-prep branch 5 times, most recently from 682a59d to 6715415 Compare May 26, 2021 23:24
@nuttycom nuttycom requested review from therealyingtong and str4d May 26, 2021 23:25
@nuttycom nuttycom force-pushed the feature/zip-225-prep branch 2 times, most recently from 50ec4b3 to 62c454f Compare May 27, 2021 14:29
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK after changes.

zcash_primitives/src/consensus.rs Outdated Show resolved Hide resolved
zcash_primitives/src/sapling.rs Outdated Show resolved Hide resolved
zcash_primitives/src/sapling.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remembered that we should be documenting things in the changelogs 😅

zcash_primitives/src/transaction/mod.rs Show resolved Hide resolved
zcash_primitives/src/sapling.rs Show resolved Hide resolved
zcash_primitives/src/consensus.rs Show resolved Hide resolved
zcash_primitives/src/consensus.rs Show resolved Hide resolved
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Changelog changes can be done in a subsequent PR.

@str4d
Copy link
Contributor

str4d commented Jun 1, 2021

Needs a rebase now (because the changelog changes conflict).

@str4d
Copy link
Contributor

str4d commented Jun 1, 2021

Also cargo fmt.

@nuttycom nuttycom force-pushed the feature/zip-225-prep branch from 475a1ef to 168314c Compare June 1, 2021 13:05
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 168314c

Copy link
Contributor

@therealyingtong therealyingtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 168314c

@nuttycom nuttycom merged commit 010a537 into zcash:master Jun 2, 2021
@nuttycom nuttycom deleted the feature/zip-225-prep branch June 2, 2021 15:39
@str4d str4d mentioned this pull request Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-committed Status: Planned work in a sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants