-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for storybook 6.4/6.5, CSF3 and HMR fix #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyhw
changed the title
feat: support for 6.5 story store
feat: support for storybook 6.4/6.5 new story store and CSF3
Oct 30, 2022
dannyhw
changed the title
feat: support for storybook 6.4/6.5 new story store and CSF3
feat: support for storybook 6.4/6.5, CSF3 and HMR fix
Oct 30, 2022
This was referenced Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
This is the initial attempts at getting the new story store working in react native storybook
What I did
How to test
Early build released at 6.0.1-canary.1
Example project with a early build
https://github.com/dannyhw/react-native-storybook-6.5-example
With the introduction of this patch in 6.5 we should be able to remove the document polyfill
storybookjs/storybook#19623
also resolves #30