Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fast refresh #30

Closed
wants to merge 5 commits into from
Closed

Fix Fast refresh #30

wants to merge 5 commits into from

Conversation

Gongreg
Copy link
Member

@Gongreg Gongreg commented Feb 15, 2020

Issue: #11

What I did

Updated getStorybookUI to reuse channel on rerender.

TODO

  • Update story list to not jump around on fast refresh.
  • Make a PR to main storybook to fix ClientAPI.

How to test

  • Still manual testing for cases like these.

@vercel
Copy link

vercel bot commented Feb 15, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/react-native/df4j2dz97
✅ Preview: https://react-native-git-fast-refresh.storybook.now.sh

@github-actions
Copy link

github-actions bot commented Feb 15, 2020

Fails
🚫 PR is marked with "in progress" label.

Generated by 🚫 dangerJS against 3024509

@Gongreg
Copy link
Member Author

Gongreg commented Feb 15, 2020

@shilman, @ndelangen could you remove now bot from RN repo?

@ndelangen
Copy link
Member

I removed now.sh

@dannyhw
Copy link
Member

dannyhw commented Aug 4, 2020

rebased this with master to reevaluate the status of this pr

@dannyhw
Copy link
Member

dannyhw commented Aug 15, 2020

after looking through old issues it seems like for this to work storiesOf should be called once per file see #31.

@ndelangen
Copy link
Member

yes, storiesOf should be once per file, that's how it's also defined for CSF

@dannyhw
Copy link
Member

dannyhw commented Aug 26, 2020

this change relies on storybookjs/storybook#9868 and so we would need this change for 5.3.x in order to fix this for this version of react native storybook

@dannyhw
Copy link
Member

dannyhw commented Aug 28, 2020

storybookjs/storybook#9868 has now been released for version 5.3 with the 5.3.21 release 🥳. Should now be able to give this one another go.

@dannyhw
Copy link
Member

dannyhw commented Sep 25, 2020

I got a bit stuck with this because I was finding it really hard to reproduce in the issue in the example project. Thinking this one might be delayed for the next release.

@mohsinulhaq
Copy link
Contributor

@Gongreg any issues in this? would be really helpful if this was fixed :)

@dannyhw
Copy link
Member

dannyhw commented Nov 12, 2020

@mohsinulhaq I had issues with testing this change which makes it hard to tell if these changes work or not otherwise I would have merged it already.

Also there will be significant changes to this part of the code to support 6.0 so it might be easier fixed in 6.0.

@mohsinulhaq
Copy link
Contributor

@dannyhw No problem. Thanks!

@dannyhw dannyhw closed this May 30, 2021
@dannyhw
Copy link
Member

dannyhw commented May 30, 2021

Will be fixed as part of 6.0 CSF support etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: react-native bug Something isn't working todo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants