-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Fast refresh #30
Fix Fast refresh #30
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/react-native/df4j2dz97 |
@shilman, @ndelangen could you remove now bot from RN repo? |
I removed now.sh |
rebased this with master to reevaluate the status of this pr |
after looking through old issues it seems like for this to work storiesOf should be called once per file see #31. |
yes, storiesOf should be once per file, that's how it's also defined for CSF |
this change relies on storybookjs/storybook#9868 and so we would need this change for 5.3.x in order to fix this for this version of react native storybook |
storybookjs/storybook#9868 has now been released for version 5.3 with the 5.3.21 release 🥳. Should now be able to give this one another go. |
I got a bit stuck with this because I was finding it really hard to reproduce in the issue in the example project. Thinking this one might be delayed for the next release. |
@Gongreg any issues in this? would be really helpful if this was fixed :) |
@mohsinulhaq I had issues with testing this change which makes it hard to tell if these changes work or not otherwise I would have merged it already. Also there will be significant changes to this part of the code to support 6.0 so it might be easier fixed in 6.0. |
@dannyhw No problem. Thanks! |
Will be fixed as part of 6.0 CSF support etc. |
Issue: #11
What I did
Updated getStorybookUI to reuse channel on rerender.
TODO
How to test