-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.0] When editing a story the app will always fully reload #219
Comments
I could take a stab at this! :) |
lauriharpf
added a commit
to lauriharpf/react-native
that referenced
this issue
Jul 13, 2021
…he app). NOTE: At the moment, the app doesn't repaint when the hot reload occurs. Thus, this fix isn't usable as-is; we need to also figure out how to force the repaint so that the changes made in the hot reload are reflected.
lauriharpf
added a commit
to lauriharpf/react-native
that referenced
this issue
Jul 14, 2021
…he fast reload so that the changes get immediately reflected without interaction with the UI. FORCE_RE_RENDER is a stopgap solution: The UI doesn't seem to re-render even if React.memo is removed from OnDeviceUI.
I've moved this to alpha2 milestone. I think that we can go ahead without fast reload for now considering that the full reload now takes you back to the previous story. This seems like a difficult issue to solve so I'd rather not delay on the first alpha due to this. |
fixed in #384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When editing a story fast reload is not working correctly.
This section of code was removed from the loadCsf file and might be related (line 251)
The dispose part is not need however perhaps maintaining the hot.accept part would be useful... this needs some investigation probably.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Fast reload should be used such that only what changed gets reloaded.
The text was updated successfully, but these errors were encountered: