Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] support new storybook architecture being introduced with 6.4 #284

Closed
dannyhw opened this issue Oct 12, 2021 · 5 comments
Closed

[6.0] support new storybook architecture being introduced with 6.4 #284

dannyhw opened this issue Oct 12, 2021 · 5 comments
Assignees
Labels

Comments

@dannyhw
Copy link
Member

dannyhw commented Oct 12, 2021

Is your feature request related to a problem? Please describe.

Soon the storybook team will be merging some changes to the storybook architecture and it's necessary to make changes to this package in order for react native storybook to stay up to date.

Describe the solution you'd like

Necessary changes are made to support the new story store and api changes.

Are you able to assist bring the feature to reality?
Yes

Additional context

storybookjs/storybook#15355

@dannyhw dannyhw added the 6.5 label Oct 12, 2021
@dannyhw dannyhw added this to the 6.1 milestone Oct 12, 2021
@dannyhw dannyhw modified the milestones: 6.1, 6.0 release Dec 4, 2021
@dannyhw dannyhw self-assigned this Dec 4, 2021
@dannyhw
Copy link
Member Author

dannyhw commented Dec 4, 2021

This issue gains more priority now that 6.4 is already out. Will be working on this now.

@chico
Copy link

chico commented Jul 18, 2022

@dannyhw really appreciate you working on this 👏, any chance you might have a ballpark ETA for when it might be done? Thank you! 🤞

@Listor
Copy link

Listor commented Aug 11, 2022

Hey @dannyhw appreciate your time as well. Is there anything we can do to assist you in getting this done?

@dannyhw
Copy link
Member Author

dannyhw commented Aug 14, 2022

@chico @Listor hey thanks for the kind words, sorry for the delay responding I had holidays and stuff recently.

I've been reaching out for help on this but most people are taking holidays too. There is a branch with an initial attempt, but its still really rough and doesn't work yet https://github.com/storybookjs/react-native/tree/next-6.5. Stories weren't loading properly and its basically a case of debugging this or reworking it. I got pretty stuck with it, though I'll be coming back to it, hopefully with some help it can be sorted out.

The next alternative is that in 7.0 there are going to be some changes to make it easier for react native, however I still really want to get something out before then. I'm in talks with the web maintainers so when people are around I'll see what can be done.

@dannyhw
Copy link
Member Author

dannyhw commented Nov 5, 2022

done in #384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants