Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ax updates #65

Merged
merged 9 commits into from
Jan 13, 2023
Merged

Feature/ax updates #65

merged 9 commits into from
Jan 13, 2023

Conversation

sarah-storm
Copy link
Contributor

@sarah-storm sarah-storm commented Jan 12, 2023

Various AX fixes, bundled into one PR as most are small.

#55 - Expandable navigation - focus position

  • Updated AC to match functionality.
  • Maybe a wee bit of design input needed to think of a better way to show the 'active' link so that it's not confused with focus. Or maybe we don't need to show that at all.

#56 - Tabbable main element is confusing on example page

  • Removed tab index and added some sample content with link instead.

#57 - Full screen navigation > landscape mobile overflow hidden

  • CSS overflow fix added

#58 - Use search landmark on search patterns

  • role="search" added to search forms

#61 - Modal should be contained in a landmark

#54 - Expandable navigation - NVDA

  • This was the biggest update. Gov.uk are achiving this by toggling the aria-label when the button is used. Prior to this, our button's aria label was announced when landing on the button, but never -re-read as the button was used. NVDA will now read out an updated label when the button is pressed, but I'm not sure what thoughts are on this? Whether it might cause issues elsewhere?

@mjbp mjbp merged commit 1e8b47e into main Jan 13, 2023
@mjbp
Copy link
Collaborator

mjbp commented Jan 13, 2023

Merged with a couple of tweaks.

I think we should give the govuk navigation toggle button labelling pattern a go for now.

@mjbp mjbp deleted the feature/ax-updates branch January 13, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants