Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabbable main element is confusing on example page #56

Closed
mjbp opened this issue Nov 30, 2022 · 2 comments
Closed

Tabbable main element is confusing on example page #56

mjbp opened this issue Nov 30, 2022 · 2 comments
Assignees
@susannah-rogers
Labels
accessibility An accessibility based enhancement or bug

Comments

@mjbp
Copy link
Collaborator

mjbp commented Nov 30, 2022

The main element has a tabindex for testing purposes but I think it should be removed, it's confusing to have the documentation.
@mjbp mjbp changed the title Full screen navigation main tabindex Tabbable main element is confusing on example page Nov 30, 2022
@sarah-storm sarah-storm added the accessibility An accessibility based enhancement or bug label Dec 1, 2022
@sarah-storm sarah-storm self-assigned this Jan 12, 2023
@sarah-storm sarah-storm mentioned this issue Jan 12, 2023
Merged
@mjbp mjbp assigned susannah-rogers and unassigned sarah-storm Jan 13, 2023
@mjbp
Copy link
Collaborator Author

mjbp commented Jan 13, 2023

@susannah-rogers This is now on Netlify ready for testing.

@susannah-rogers
Copy link

@mjbp This one is much better now, thanks.

@mjbp mjbp closed this as completed Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@susannah-rogers susannah-rogers

Labels
accessibility An accessibility based enhancement or bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mjbp @sarah-storm @susannah-rogers