Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use search landmark on search patterns #58

Closed
mjbp opened this issue Nov 30, 2022 · 5 comments
Closed

Use search landmark on search patterns #58

mjbp opened this issue Nov 30, 2022 · 5 comments
Assignees
Labels
accessibility An accessibility based enhancement or bug

Comments

@mjbp
Copy link
Collaborator

mjbp commented Nov 30, 2022

Spec discussion about using role=search on form - w3c/html-aria#18

W3C spec and guidance
https://w3c.github.io/aria-practices/#aria_lh_searchy
https://w3c.github.io/aria-practices/examples/landmarks/search.html
https://w3c.github.io/aria/#search

@mjbp
Copy link
Collaborator Author

mjbp commented Nov 30, 2022

"When you expand the search, NVDA reads 'Your search'. This may not make it clear to the user that they need to start typing. GOV.UK says 'Sitewide search landmark, Search GOV.UK'. BBC says 'Main landmark, Search landmark, Input your search term'"

@sarah-storm sarah-storm added the accessibility An accessibility based enhancement or bug label Dec 1, 2022
@sarah-storm sarah-storm self-assigned this Jan 12, 2023
@mjbp mjbp assigned susannah-rogers and unassigned sarah-storm Jan 13, 2023
@mjbp
Copy link
Collaborator Author

mjbp commented Jan 13, 2023

@susannah-rogers This is now on Netlify ready for testing.

@susannah-rogers
Copy link

@mjbp thanks for adding the search landmark. NVDA now reads 'Search landmark. Your search edit has autocomplete blank' which is a definite improvement. Would it be possible for NVDA to read 'Search landmark. Input your search term'?

@mjbp
Copy link
Collaborator Author

mjbp commented Jan 26, 2023

@susannah-rogers @sarah-storm updated the visually hidden label to match your suggestion. It's on Netlify for to test at your convenience.

@mjbp mjbp assigned susannah-rogers and unassigned sarah-storm Jan 26, 2023
@susannah-rogers
Copy link

@mjbp Great, thanks. This is now working as expected.

@mjbp mjbp closed this as completed Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility An accessibility based enhancement or bug
Projects
None yet
Development

No branches or pull requests

3 participants