Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expandable navigation - focus position #55

Closed
sarah-storm opened this issue Nov 29, 2022 · 3 comments
Closed

Expandable navigation - focus position #55

sarah-storm opened this issue Nov 29, 2022 · 3 comments
Assignees
Labels
accessibility An accessibility based enhancement or bug

Comments

@sarah-storm
Copy link
Contributor

The acceptance criteria states 'The first navigation link should receive visible focus when navigation is opened' however the second navigation link receives visible focus. It would be useful to navigate to each of the item pages rather than just one

@sarah-storm sarah-storm added the accessibility An accessibility based enhancement or bug label Nov 29, 2022
@mjbp
Copy link
Collaborator

mjbp commented Nov 30, 2022

Focus remains on the button for me on everything I've tested on. The menu item is highlighted because it is the active one, so that may be a source of confusion.

I think that focus remaining on the button is the correct thing to happen so the expanded state is announced when the button is activated. The navigation items are next in the tab order after the button.

I think there are a couple of things we should change with this pattern

  • the AC is wrong, I think focus should remain on the button
  • the styling of the menu is worth revisiting, it's not great

@sarah-storm sarah-storm self-assigned this Jan 12, 2023
@mjbp mjbp assigned mjbp and susannah-rogers and unassigned sarah-storm and mjbp Jan 13, 2023
@mjbp
Copy link
Collaborator

mjbp commented Jan 13, 2023

@susannah-rogers This is now on Netlify ready for testing.

@susannah-rogers
Copy link

@mjbp This is much better now, thanks.

@mjbp mjbp closed this as completed Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility An accessibility based enhancement or bug
Projects
None yet
Development

No branches or pull requests

3 participants