Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When used with Containerise, tabs open twice and get focus #15

Closed
shvchk opened this issue Dec 26, 2017 · 13 comments
Closed

When used with Containerise, tabs open twice and get focus #15

shvchk opened this issue Dec 26, 2017 · 13 comments

Comments

@shvchk
Copy link

shvchk commented Dec 26, 2017

When used with Containerise, links open twice (second tab with the same links is opened and almost always instantly closed, but sometimes it stays). This slows down page loading and also makes almost every link appear in history twice. Also, if link was opened in background tab, that tab gets focused, so you always have to switch back to the parent tab.

@stoically stoically added the bug label Dec 27, 2017
@stoically
Copy link
Owner

Hi, could you provide informations on how to exactly reproduce this bug?

  • Settings in Containerise
  • Settings in Temporary Containers
  • What and how to click

Thanks.

@dakka2
Copy link

dakka2 commented Jan 22, 2018

Seems to happen in automatic mode ctrl left clicking links. Additionally happens opening new blank tabs (opens two blank tabs). It's not containerize specific, I saw it happen with another addon but can't recall what it was called.

@stoically
Copy link
Owner

stoically commented Jan 23, 2018

When I Ctrl+LeftClick a link in a tmpcontainer that is bound to a permanent container using Containerise, it correctly opens only one Tab in the assigned permanent container for me.

Pressing Ctrl+T also only opens one New Tab in a temporary container for me.

Unfortunately I can't do anything without exact steps how to reproduce. Other helpful informations beside the ones asked in my previous comment would be the versions of Firefox and the Addons and which Operating System.

If it's not always reproducible I'd need a debug log for the case in which it happens. It can be obtained by going to about:debugging, Enable Debugging, Clicking on "Debug" next to "Temporary Containers" and executing log.DEBUG = true; in the DevTools Console. Then Copy&(No)Paste the whole log for the case in which it happens.

@schnittchen
Copy link

I have the same problem. I am not using the containerized extension, but IIRC the feature has been integrated by now. The behaviour is linked with the "Always open in " feature.

Recently, this has gotten worse: When following a link, a new tab would open and shortly after close again.

Right now this prevents me from using this extension, although I love the idea.

@stoically
Copy link
Owner

stoically commented Jan 25, 2018

In general, if you upgraded to Firefox58 (or used a version > 57 before already), those versions have a bug that I was able to reproduce regarding opening of two tabs, see #20 - unfortunately the published version 0.20 introduced a regression and I had to deactivate. This is happens because of race-conditions with MAC and is really hard to fix in a sane way. I'll try to get a workaround ready and will look into opening a PullRequest for MAC that introduces some sort of API.

@schnittchen If you can reproduce the unexpected closing of Tabs bug I'd appreciate if you could open a new Issue with browser/addon versions+settings and how to reproduce.

@stoically
Copy link
Owner

stoically commented Jan 28, 2018

Just released a fix for #20

@shvchk Could you please test if the problem still exists with the latest version? Thanks.

@stoically
Copy link
Owner

stoically commented Jan 28, 2018

@dakka2 Could you also test if the problem still exists for you?

@stoically
Copy link
Owner

To fully support Containerise we would need them to implement something similar to mozilla/multi-account-containers#1095. After #29 is done I will look into opening a Pull request with Containerise.

@Gitoffthelawn
Copy link

Gitoffthelawn commented Mar 22, 2018

I don't use Containerise, but am experiencing a similar issue (currently on FF60.0b5, but have experienced this issue for several versions). I'll try to narrow down what might be causing it as soon as I have a little time.

@stoically
Copy link
Owner

@Gitoffthelawn Would be great if you could open a new Issue if you find the time to reproduce, since this Issue should be kept Containerise-specific.

Regarding Containerise: There's a pending Pull request now kintesh/containerise#18 - compatibility can finally be achieved if that gets merged.

@Gitoffthelawn
Copy link

@stoically Will do.

@Gitoffthelawn
Copy link

Done. See #106

@stoically
Copy link
Owner

Published version 0.90 with containerise support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants