Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specific extensions to ask for hostmap #18

Merged
merged 1 commit into from
Mar 25, 2018
Merged

Allow specific extensions to ask for hostmap #18

merged 1 commit into from
Mar 25, 2018

Conversation

stoically
Copy link
Contributor

Resolves #17

@stoically stoically mentioned this pull request Mar 22, 2018
Closed
kintesh
kintesh approved these changes Mar 25, 2018
View reviewed changes
Copy link
Owner

@kintesh kintesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should start writing tests for all the files. I'll merge it now and write it later before releasing new version to AMO.

@kintesh kintesh merged commit bc4e101 into kintesh:master Mar 25, 2018
@stoically stoically deleted the external-messages branch March 26, 2018 21:41
@stoically
Copy link
Contributor Author

Thanks for merging. Let me know if you need some input regarding testing.

@stoically stoically mentioned this pull request May 2, 2018
Closed
@stoically stoically mentioned this pull request May 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kintesh kintesh kintesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stoically @kintesh