Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API to check whether an URL is assigned #17

Closed
stoically opened this issue Feb 25, 2018 · 5 comments
Closed

API to check whether an URL is assigned #17

stoically opened this issue Feb 25, 2018 · 5 comments

Comments

@stoically
Copy link
Contributor

stoically commented Feb 25, 2018

Hi,

@shvchk asked if it would be possible to support your Add-on in combination with mine here: stoically/temporary-containers#15

For that to work properly I'd need an API to ask your Add-on whether a specific URL is assigned. Here's how Multi-Account Containers is doing it: mozilla/multi-account-containers#1130 (comment)

Would you be up to implement something like that or accept Pull requests implementing it?

Best regards

@kintesh
Copy link
Owner

kintesh commented Feb 25, 2018

I am heppy for you to create a PR.

@stoically
Copy link
Contributor Author

Before I start working on this it would be good to know in what way you would want to see it implemented. It would require adding runtime.onMessageExternal - now the question is, who should be able to get an answer? The options I see are:

  • Adding the management permission and checking for contextualIdentities permission
  • Adding a whitelist that has to be manually maintained
  • Just answering whoever asks

@kintesh
Copy link
Owner

kintesh commented Mar 10, 2018

I think it best to lock it down to specific id and manually maintaining it. The way I see it is that this extentions won't change much from what it is now.

@shvchk
Copy link
Contributor

shvchk commented Mar 10, 2018

Just wanted to thank @stoically and @kintesh for working on this and container stuff in general. You guys are awesome! 🤘

@innir
Copy link

innir commented Mar 29, 2018

@kintesh Would you mind releasing a new version? Currently I can't use containerise because of this.
BTW: Thanks for your extension, it is really the last missing piece to get a smooth container experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants