Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring to use the Multi-Account Containers API #29

Closed
4 tasks done
stoically opened this issue Feb 1, 2018 · 1 comment
Closed
4 tasks done

Refactoring to use the Multi-Account Containers API #29

stoically opened this issue Feb 1, 2018 · 1 comment
Labels
enhancement
Milestone
v1.0

Comments

@stoically
Copy link
Owner

stoically commented Feb 1, 2018 •
edited
Loading

Since mozilla/multi-account-containers#1095 is probably going to get got merged it's possible to remove most of the hacky MAC-handling code.

  • Move everything that's now related to MAC handling into its own file and call it legacy
  • Implement handling of MAC with the API (waiting until PR merge into master)
  • Drop MAC legacy support
  • Write tests for new MAC handling
@stoically stoically changed the title Refactoring to use the Multi-Account Container API Refactoring to use the Multi-Account Containers API Feb 2, 2018
This was referenced Feb 2, 2018
Closed
Closed
Closed
Closed
stoically added a commit that referenced this issue Feb 2, 2018
@stoically
Initial split of legacy MAC handling code
4fe9a76 
Part of #29
This was referenced Feb 5, 2018
Closed
Closed
This was referenced Feb 15, 2018
Closed
Closed
stoically added a commit that referenced this issue Feb 23, 2018
@stoically
Refactoring to use the Multi-Account Containers API
47042c6 
Part of #29
stoically added a commit that referenced this issue Feb 23, 2018
@stoically
More refactoring towards MAC API
d656503 
Part of #29
stoically added a commit that referenced this issue Feb 23, 2018
@stoically
Drop MAC legacy support
58295e2 
Part of #29
stoically added a commit that referenced this issue Feb 23, 2018
@stoically
Respect that MAC wants to stay in permanent containers for assigned urls
b9d88e0 
Part of #29
stoically added a commit that referenced this issue Feb 23, 2018
@stoically
MAC handling tests
6e6d4ed 
Part of #29
stoically added a commit that referenced this issue Feb 23, 2018
@stoically
More extensive MAC tests with preferences-combinations
3733e42 
Part of #29
stoically added a commit that referenced this issue Feb 23, 2018
@stoically
More MAC handling and tests
3df277c 
Part of #29
stoically added a commit that referenced this issue Feb 24, 2018
@stoically
That should cover most of the MAC handling now
355c537 
Part of #29
@stoically
Copy link
Owner Author

Published version 0.58 with the refactoring. Requires MAC version 6.0.0

stoically added a commit that referenced this issue Feb 24, 2018
@stoically
MAC edge-cases, gotta catch them all
c957da2 
Part of #29
@stoically stoically mentioned this issue Feb 26, 2018
Closed
@stoically stoically added this to the v1.0 milestone Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
1 participant
@stoically