Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.63 Occasionally Opens Multiple Tabs for the Same Link #66

Closed
rue opened this issue Feb 26, 2018 · 4 comments
Closed

0.63 Occasionally Opens Multiple Tabs for the Same Link #66

rue opened this issue Feb 26, 2018 · 4 comments

Comments

@rue
Copy link

rue commented Feb 26, 2018

Noticed this happening today, and probably not coincidentally latest TC update was today.

  • Temporary Containers Version: 0.63
  • Firefox Version: 58.0.2
  • Operating System + Version: OS X 10.13.2
  • Non-default Options/Preferences in Temporary Containers: Mouse Clicks -> Ctrl/Cmd+Left Mouse -> only if not in same domain (maybe others, will add)
  • Other installed Add-ons + Version: Multi-Account Containers 5.0.1

Actual behavior

Upon Cmd-clicking a link from Firefox or Mail.app, sometimes (not always) Firefox keeps opening multiple tabs for the link. Trying to close these tabs opens more of them until presumably some total number are open, at which point the tabs can be closed.

I’ll try to add a repro later when I have time (and unless this is enough info for you to figure out what might be going wrong).

Expected behavior

A single tab is opened with the correct page.

Steps to reproduce

TBA

Notes

TBA

@rue rue changed the title 0.63 Occasionally Opens Multiple of Tabs (of the Same Page) 0.63 Occasionally Opens Multiple Tabs for the Same Link Feb 26, 2018
@stoically
Copy link
Owner

stoically commented Feb 26, 2018

Hi, I'm guessing the link you're opening is assigned using Multi-Account Containers and you're in Automatic Mode? In that case, this can (and will) happen because since version 0.58 TC needs MAC version 6.0.0 or higher (see AMO release notes, #29 and #24). If it's not an assigned link and/or you're not in Automatic Mode, further information (maybe even a debug log) would be greatly appreciated.

However, TC shouldn't go completely bonkers in Automatic Mode with MAC versions below 6.0.0 if the link is assigned, I'm gonna add a safety measure. Unfortunately there's nothing I can do to prevent the combination of TC 0.58+ and MAC <6 doing unexpected things.

The good news is, that with MAC version 6.0.0 TC now works way better, because MAC introduced an API to query for assignment-information.

@go2null
Copy link

go2null commented Feb 27, 2018

Figured out the same as stated by @stoically - only happens if domain is assigned a regular container with MAC.

MAC 6.0.0 is available on Mozilla Add-ons; so I manually upgraded.

Issue not observed since.

@rue
Copy link
Author

rue commented Feb 27, 2018

Same repro, and problem’s gone with MAC 6.0.0. Thanks!

@go2null
Copy link

go2null commented Mar 2, 2018

confirmed fixed: on one of my machines, had <6.0.0 MAC and issues occured; upgraded MAC to 6.0.0 and no problem with same link as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants