Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug TransactionProcessor performance #3256

Closed
bartekn opened this issue Nov 26, 2020 · 2 comments · Fixed by #3257
Closed

Debug TransactionProcessor performance #3256

bartekn opened this issue Nov 26, 2020 · 2 comments · Fixed by #3257
Labels
horizon ingest New ingestion system performance issues aimed at improving performance

Comments

@bartekn
Copy link
Contributor

bartekn commented Nov 26, 2020 •
edited
Loading

Similar to #3246 (with #3224) I realized that TransactionProcessor is slower than it should be:

Screenshot 2020-11-26 at 16 04 08

Compared to OperationProcessor (yellow line), which inserts much more rows, it can be 3x slower. We should debug it and understand where is the bottleneck.
@bartekn bartekn added horizon ingest New ingestion system performance issues aimed at improving performance labels Nov 26, 2020
@bartekn bartekn mentioned this issue Nov 26, 2020
Merged
7 tasks
@bartekn
Copy link
Contributor Author

bartekn commented Nov 27, 2020

Accidentally closed in #3257 that should close #3238. Reopening.

@bartekn bartekn reopened this Nov 27, 2020
@bartekn
Copy link
Contributor Author

bartekn commented Dec 23, 2020

The slowness is connected to marshaling and then encoding to base64 of some transaction related XDR objects. Nothing can be done here except making XDR encoder faster which is already tracked in #2689.

Screenshot 2020-12-23 at 17 46 36

@bartekn bartekn closed this as completed Dec 23, 2020
@bartekn bartekn mentioned this issue Sep 13, 2021
Closed
@ire-and-curses ire-and-curses mentioned this issue Oct 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
horizon ingest New ingestion system performance issues aimed at improving performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ingest/ledgerbackend: Add prev ledger hash check to CaptiveStellarCore bartekn/go
1 participant
@bartekn