Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch OffersProcessor database operations #3913

Closed
bartekn opened this issue Sep 13, 2021 · 0 comments · Fixed by #3917
Closed

Batch OffersProcessor database operations #3913

bartekn opened this issue Sep 13, 2021 · 0 comments · Fixed by #3917
Assignees
@bartekn
Labels
bug horizon performance issues aimed at improving performance

Comments

@bartekn
Copy link
Contributor

bartekn commented Sep 13, 2021 •
edited
Loading

What version are you using?

2.8.1

What did you do?

Noticed that OffersProcessor became really slow, even slower than TransactionsProcessor (#3256). This is likely because we Add/Update/Remove offers without batching. We should implement batching as we do in AccountsProcessor.

OffersProcessor vs TransactionsProcessor for comparison:
Screenshot 2021-09-13 at 23 48 37
@bartekn bartekn added horizon bug performance issues aimed at improving performance labels Sep 13, 2021
@bartekn bartekn changed the title Optimize OffersProcessor database operations Batch OffersProcessor database operations Sep 13, 2021
@bartekn bartekn self-assigned this Sep 14, 2021
@bartekn bartekn linked a pull request Sep 14, 2021 that will close this issue
services/horizon/ingest: Batch Offers insert/updates #3917
Merged
7 tasks
@bartekn bartekn mentioned this issue Sep 14, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartekn bartekn

Labels
bug horizon performance issues aimed at improving performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

services/horizon/ingest: Batch Offers insert/updates bartekn/go
1 participant
@bartekn