Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check/update PreviousLedgerHash in CaptiveStellarCore.GetLedger #3238

Closed
bartekn opened this issue Nov 20, 2020 · 1 comment
Closed

Check/update PreviousLedgerHash in CaptiveStellarCore.GetLedger #3238

bartekn opened this issue Nov 20, 2020 · 1 comment
Assignees
@bartekn
Labels
fast-txmeta

Comments

@bartekn
Copy link
Contributor

bartekn commented Nov 20, 2020 •
edited
Loading

Each LedgerHeaderHistoryEntry contains the current ledger hash (Hash) and previous ledger hash (Header.PreviousLedgerHash), this way ledgers form a chain. We should compare current ledger PreviousLedgerHash with the last processed ledger Hash. This can prevent some bugs in the future in which ledgers are processed out of order (and sequence number check fails).
@bartekn bartekn self-assigned this Nov 26, 2020
@bartekn bartekn mentioned this issue Nov 27, 2020
Closed
@bartekn
Copy link
Contributor Author

bartekn commented Nov 27, 2020

Closed in #3238.

@bartekn bartekn closed this as completed Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartekn bartekn

Labels
fast-txmeta
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bartekn