Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest/ledgerbackend: Add prev ledger hash check to CaptiveStellarCore #3257

Merged
merged 3 commits into from
Nov 27, 2020

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Nov 26, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Adds an extra check in GetLedger checking if previously read ledger header match the current ledger previous hash.

Close #3256.

Why

CaptiveStellarCore reads ledgers in a strict increasing order. It's worth checking if the previous hash is match to ensure we receive ledgers in correct order.

@bartekn bartekn requested a review from a team November 26, 2020 17:58
@cla-bot cla-bot bot added the cla: yes label Nov 26, 2020
@bartekn bartekn changed the title ingest/ledgerbackend: Get prev ledger hash check to CaptiveStellarCore ingest/ledgerbackend: Add prev ledger hash check to CaptiveStellarCore Nov 26, 2020
@bartekn bartekn merged commit 7fa5a54 into stellar:master Nov 27, 2020
@bartekn bartekn deleted the captive-check-prev-hash branch November 27, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug TransactionProcessor performance
2 participants